linux/scripts/checkpatch.pl
<<
>>
Prefs
   1#!/usr/bin/perl -w
   2# (c) 2001, Dave Jones. (the file handling bit)
   3# (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
   4# (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
   5# (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
   6# Licensed under the terms of the GNU GPL License version 2
   7
   8use strict;
   9
  10my $P = $0;
  11$P =~ s@.*/@@g;
  12
  13my $V = '0.32';
  14
  15use Getopt::Long qw(:config no_auto_abbrev);
  16
  17my $quiet = 0;
  18my $tree = 1;
  19my $chk_signoff = 1;
  20my $chk_patch = 1;
  21my $tst_only;
  22my $emacs = 0;
  23my $terse = 0;
  24my $file = 0;
  25my $check = 0;
  26my $summary = 1;
  27my $mailback = 0;
  28my $summary_file = 0;
  29my $show_types = 0;
  30my $root;
  31my %debug;
  32my %ignore_type = ();
  33my @ignore = ();
  34my $help = 0;
  35my $configuration_file = ".checkpatch.conf";
  36
  37sub help {
  38        my ($exitcode) = @_;
  39
  40        print << "EOM";
  41Usage: $P [OPTION]... [FILE]...
  42Version: $V
  43
  44Options:
  45  -q, --quiet                quiet
  46  --no-tree                  run without a kernel tree
  47  --no-signoff               do not check for 'Signed-off-by' line
  48  --patch                    treat FILE as patchfile (default)
  49  --emacs                    emacs compile window format
  50  --terse                    one line per report
  51  -f, --file                 treat FILE as regular source file
  52  --subjective, --strict     enable more subjective tests
  53  --ignore TYPE(,TYPE2...)   ignore various comma separated message types
  54  --show-types               show the message "types" in the output
  55  --root=PATH                PATH to the kernel tree root
  56  --no-summary               suppress the per-file summary
  57  --mailback                 only produce a report in case of warnings/errors
  58  --summary-file             include the filename in summary
  59  --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
  60                             'values', 'possible', 'type', and 'attr' (default
  61                             is all off)
  62  --test-only=WORD           report only warnings/errors containing WORD
  63                             literally
  64  -h, --help, --version      display this help and exit
  65
  66When FILE is - read standard input.
  67EOM
  68
  69        exit($exitcode);
  70}
  71
  72my $conf = which_conf($configuration_file);
  73if (-f $conf) {
  74        my @conf_args;
  75        open(my $conffile, '<', "$conf")
  76            or warn "$P: Can't find a readable $configuration_file file $!\n";
  77
  78        while (<$conffile>) {
  79                my $line = $_;
  80
  81                $line =~ s/\s*\n?$//g;
  82                $line =~ s/^\s*//g;
  83                $line =~ s/\s+/ /g;
  84
  85                next if ($line =~ m/^\s*#/);
  86                next if ($line =~ m/^\s*$/);
  87
  88                my @words = split(" ", $line);
  89                foreach my $word (@words) {
  90                        last if ($word =~ m/^#/);
  91                        push (@conf_args, $word);
  92                }
  93        }
  94        close($conffile);
  95        unshift(@ARGV, @conf_args) if @conf_args;
  96}
  97
  98GetOptions(
  99        'q|quiet+'      => \$quiet,
 100        'tree!'         => \$tree,
 101        'signoff!'      => \$chk_signoff,
 102        'patch!'        => \$chk_patch,
 103        'emacs!'        => \$emacs,
 104        'terse!'        => \$terse,
 105        'f|file!'       => \$file,
 106        'subjective!'   => \$check,
 107        'strict!'       => \$check,
 108        'ignore=s'      => \@ignore,
 109        'show-types!'   => \$show_types,
 110        'root=s'        => \$root,
 111        'summary!'      => \$summary,
 112        'mailback!'     => \$mailback,
 113        'summary-file!' => \$summary_file,
 114
 115        'debug=s'       => \%debug,
 116        'test-only=s'   => \$tst_only,
 117        'h|help'        => \$help,
 118        'version'       => \$help
 119) or help(1);
 120
 121help(0) if ($help);
 122
 123my $exit = 0;
 124
 125if ($#ARGV < 0) {
 126        print "$P: no input files\n";
 127        exit(1);
 128}
 129
 130@ignore = split(/,/, join(',',@ignore));
 131foreach my $word (@ignore) {
 132        $word =~ s/\s*\n?$//g;
 133        $word =~ s/^\s*//g;
 134        $word =~ s/\s+/ /g;
 135        $word =~ tr/[a-z]/[A-Z]/;
 136
 137        next if ($word =~ m/^\s*#/);
 138        next if ($word =~ m/^\s*$/);
 139
 140        $ignore_type{$word}++;
 141}
 142
 143my $dbg_values = 0;
 144my $dbg_possible = 0;
 145my $dbg_type = 0;
 146my $dbg_attr = 0;
 147for my $key (keys %debug) {
 148        ## no critic
 149        eval "\${dbg_$key} = '$debug{$key}';";
 150        die "$@" if ($@);
 151}
 152
 153my $rpt_cleaners = 0;
 154
 155if ($terse) {
 156        $emacs = 1;
 157        $quiet++;
 158}
 159
 160if ($tree) {
 161        if (defined $root) {
 162                if (!top_of_kernel_tree($root)) {
 163                        die "$P: $root: --root does not point at a valid tree\n";
 164                }
 165        } else {
 166                if (top_of_kernel_tree('.')) {
 167                        $root = '.';
 168                } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
 169                                                top_of_kernel_tree($1)) {
 170                        $root = $1;
 171                }
 172        }
 173
 174        if (!defined $root) {
 175                print "Must be run from the top-level dir. of a kernel tree\n";
 176                exit(2);
 177        }
 178}
 179
 180my $emitted_corrupt = 0;
 181
 182our $Ident      = qr{
 183                        [A-Za-z_][A-Za-z\d_]*
 184                        (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
 185                }x;
 186our $Storage    = qr{extern|static|asmlinkage};
 187our $Sparse     = qr{
 188                        __user|
 189                        __kernel|
 190                        __force|
 191                        __iomem|
 192                        __must_check|
 193                        __init_refok|
 194                        __kprobes|
 195                        __ref|
 196                        __rcu
 197                }x;
 198
 199# Notes to $Attribute:
 200# We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
 201our $Attribute  = qr{
 202                        const|
 203                        __percpu|
 204                        __nocast|
 205                        __safe|
 206                        __bitwise__|
 207                        __packed__|
 208                        __packed2__|
 209                        __naked|
 210                        __maybe_unused|
 211                        __always_unused|
 212                        __noreturn|
 213                        __used|
 214                        __cold|
 215                        __noclone|
 216                        __deprecated|
 217                        __read_mostly|
 218                        __kprobes|
 219                        __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
 220                        ____cacheline_aligned|
 221                        ____cacheline_aligned_in_smp|
 222                        ____cacheline_internodealigned_in_smp|
 223                        __weak
 224                  }x;
 225our $Modifier;
 226our $Inline     = qr{inline|__always_inline|noinline};
 227our $Member     = qr{->$Ident|\.$Ident|\[[^]]*\]};
 228our $Lval       = qr{$Ident(?:$Member)*};
 229
 230our $Constant   = qr{(?i:(?:[0-9]+|0x[0-9a-f]+)[ul]*)};
 231our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
 232our $Compare    = qr{<=|>=|==|!=|<|>};
 233our $Operators  = qr{
 234                        <=|>=|==|!=|
 235                        =>|->|<<|>>|<|>|!|~|
 236                        &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
 237                  }x;
 238
 239our $NonptrType;
 240our $Type;
 241our $Declare;
 242
 243our $NON_ASCII_UTF8     = qr{
 244        [\xC2-\xDF][\x80-\xBF]               # non-overlong 2-byte
 245        |  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
 246        | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
 247        |  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
 248        |  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
 249        | [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
 250        |  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
 251}x;
 252
 253our $UTF8       = qr{
 254        [\x09\x0A\x0D\x20-\x7E]              # ASCII
 255        | $NON_ASCII_UTF8
 256}x;
 257
 258our $typeTypedefs = qr{(?x:
 259        (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
 260        atomic_t
 261)};
 262
 263our $logFunctions = qr{(?x:
 264        printk(?:_ratelimited|_once|)|
 265        [a-z0-9]+_(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
 266        WARN(?:_RATELIMIT|_ONCE|)|
 267        panic|
 268        MODULE_[A-Z_]+
 269)};
 270
 271our $signature_tags = qr{(?xi:
 272        Signed-off-by:|
 273        Acked-by:|
 274        Tested-by:|
 275        Reviewed-by:|
 276        Reported-by:|
 277        To:|
 278        Cc:
 279)};
 280
 281our @typeList = (
 282        qr{void},
 283        qr{(?:unsigned\s+)?char},
 284        qr{(?:unsigned\s+)?short},
 285        qr{(?:unsigned\s+)?int},
 286        qr{(?:unsigned\s+)?long},
 287        qr{(?:unsigned\s+)?long\s+int},
 288        qr{(?:unsigned\s+)?long\s+long},
 289        qr{(?:unsigned\s+)?long\s+long\s+int},
 290        qr{unsigned},
 291        qr{float},
 292        qr{double},
 293        qr{bool},
 294        qr{struct\s+$Ident},
 295        qr{union\s+$Ident},
 296        qr{enum\s+$Ident},
 297        qr{${Ident}_t},
 298        qr{${Ident}_handler},
 299        qr{${Ident}_handler_fn},
 300);
 301our @modifierList = (
 302        qr{fastcall},
 303);
 304
 305our $allowed_asm_includes = qr{(?x:
 306        irq|
 307        memory
 308)};
 309# memory.h: ARM has a custom one
 310
 311sub build_types {
 312        my $mods = "(?x:  \n" . join("|\n  ", @modifierList) . "\n)";
 313        my $all = "(?x:  \n" . join("|\n  ", @typeList) . "\n)";
 314        $Modifier       = qr{(?:$Attribute|$Sparse|$mods)};
 315        $NonptrType     = qr{
 316                        (?:$Modifier\s+|const\s+)*
 317                        (?:
 318                                (?:typeof|__typeof__)\s*\([^\)]*\)|
 319                                (?:$typeTypedefs\b)|
 320                                (?:${all}\b)
 321                        )
 322                        (?:\s+$Modifier|\s+const)*
 323                  }x;
 324        $Type   = qr{
 325                        $NonptrType
 326                        (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*|\[\])+|(?:\s*\[\s*\])+)?
 327                        (?:\s+$Inline|\s+$Modifier)*
 328                  }x;
 329        $Declare        = qr{(?:$Storage\s+)?$Type};
 330}
 331build_types();
 332
 333
 334our $Typecast   = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
 335
 336# Using $balanced_parens, $LvalOrFunc, or $FuncArg
 337# requires at least perl version v5.10.0
 338# Any use must be runtime checked with $^V
 339
 340our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
 341our $LvalOrFunc = qr{($Lval)\s*($balanced_parens{0,1})\s*};
 342our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
 343
 344sub deparenthesize {
 345        my ($string) = @_;
 346        return "" if (!defined($string));
 347        $string =~ s@^\s*\(\s*@@g;
 348        $string =~ s@\s*\)\s*$@@g;
 349        $string =~ s@\s+@ @g;
 350        return $string;
 351}
 352
 353$chk_signoff = 0 if ($file);
 354
 355my @dep_includes = ();
 356my @dep_functions = ();
 357my $removal = "Documentation/feature-removal-schedule.txt";
 358if ($tree && -f "$root/$removal") {
 359        open(my $REMOVE, '<', "$root/$removal") ||
 360                                die "$P: $removal: open failed - $!\n";
 361        while (<$REMOVE>) {
 362                if (/^Check:\s+(.*\S)/) {
 363                        for my $entry (split(/[, ]+/, $1)) {
 364                                if ($entry =~ m@include/(.*)@) {
 365                                        push(@dep_includes, $1);
 366
 367                                } elsif ($entry !~ m@/@) {
 368                                        push(@dep_functions, $entry);
 369                                }
 370                        }
 371                }
 372        }
 373        close($REMOVE);
 374}
 375
 376my @rawlines = ();
 377my @lines = ();
 378my $vname;
 379for my $filename (@ARGV) {
 380        my $FILE;
 381        if ($file) {
 382                open($FILE, '-|', "diff -u /dev/null $filename") ||
 383                        die "$P: $filename: diff failed - $!\n";
 384        } elsif ($filename eq '-') {
 385                open($FILE, '<&STDIN');
 386        } else {
 387                open($FILE, '<', "$filename") ||
 388                        die "$P: $filename: open failed - $!\n";
 389        }
 390        if ($filename eq '-') {
 391                $vname = 'Your patch';
 392        } else {
 393                $vname = $filename;
 394        }
 395        while (<$FILE>) {
 396                chomp;
 397                push(@rawlines, $_);
 398        }
 399        close($FILE);
 400        if (!process($filename)) {
 401                $exit = 1;
 402        }
 403        @rawlines = ();
 404        @lines = ();
 405}
 406
 407exit($exit);
 408
 409sub top_of_kernel_tree {
 410        my ($root) = @_;
 411
 412        my @tree_check = (
 413                "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
 414                "README", "Documentation", "arch", "include", "drivers",
 415                "fs", "init", "ipc", "kernel", "lib", "scripts",
 416        );
 417
 418        foreach my $check (@tree_check) {
 419                if (! -e $root . '/' . $check) {
 420                        return 0;
 421                }
 422        }
 423        return 1;
 424}
 425
 426sub parse_email {
 427        my ($formatted_email) = @_;
 428
 429        my $name = "";
 430        my $address = "";
 431        my $comment = "";
 432
 433        if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
 434                $name = $1;
 435                $address = $2;
 436                $comment = $3 if defined $3;
 437        } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
 438                $address = $1;
 439                $comment = $2 if defined $2;
 440        } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
 441                $address = $1;
 442                $comment = $2 if defined $2;
 443                $formatted_email =~ s/$address.*$//;
 444                $name = $formatted_email;
 445                $name =~ s/^\s+|\s+$//g;
 446                $name =~ s/^\"|\"$//g;
 447                # If there's a name left after stripping spaces and
 448                # leading quotes, and the address doesn't have both
 449                # leading and trailing angle brackets, the address
 450                # is invalid. ie:
 451                #   "joe smith joe@smith.com" bad
 452                #   "joe smith <joe@smith.com" bad
 453                if ($name ne "" && $address !~ /^<[^>]+>$/) {
 454                        $name = "";
 455                        $address = "";
 456                        $comment = "";
 457                }
 458        }
 459
 460        $name =~ s/^\s+|\s+$//g;
 461        $name =~ s/^\"|\"$//g;
 462        $address =~ s/^\s+|\s+$//g;
 463        $address =~ s/^\<|\>$//g;
 464
 465        if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
 466                $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
 467                $name = "\"$name\"";
 468        }
 469
 470        return ($name, $address, $comment);
 471}
 472
 473sub format_email {
 474        my ($name, $address) = @_;
 475
 476        my $formatted_email;
 477
 478        $name =~ s/^\s+|\s+$//g;
 479        $name =~ s/^\"|\"$//g;
 480        $address =~ s/^\s+|\s+$//g;
 481
 482        if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
 483                $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
 484                $name = "\"$name\"";
 485        }
 486
 487        if ("$name" eq "") {
 488                $formatted_email = "$address";
 489        } else {
 490                $formatted_email = "$name <$address>";
 491        }
 492
 493        return $formatted_email;
 494}
 495
 496sub which_conf {
 497        my ($conf) = @_;
 498
 499        foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
 500                if (-e "$path/$conf") {
 501                        return "$path/$conf";
 502                }
 503        }
 504
 505        return "";
 506}
 507
 508sub expand_tabs {
 509        my ($str) = @_;
 510
 511        my $res = '';
 512        my $n = 0;
 513        for my $c (split(//, $str)) {
 514                if ($c eq "\t") {
 515                        $res .= ' ';
 516                        $n++;
 517                        for (; ($n % 8) != 0; $n++) {
 518                                $res .= ' ';
 519                        }
 520                        next;
 521                }
 522                $res .= $c;
 523                $n++;
 524        }
 525
 526        return $res;
 527}
 528sub copy_spacing {
 529        (my $res = shift) =~ tr/\t/ /c;
 530        return $res;
 531}
 532
 533sub line_stats {
 534        my ($line) = @_;
 535
 536        # Drop the diff line leader and expand tabs
 537        $line =~ s/^.//;
 538        $line = expand_tabs($line);
 539
 540        # Pick the indent from the front of the line.
 541        my ($white) = ($line =~ /^(\s*)/);
 542
 543        return (length($line), length($white));
 544}
 545
 546my $sanitise_quote = '';
 547
 548sub sanitise_line_reset {
 549        my ($in_comment) = @_;
 550
 551        if ($in_comment) {
 552                $sanitise_quote = '*/';
 553        } else {
 554                $sanitise_quote = '';
 555        }
 556}
 557sub sanitise_line {
 558        my ($line) = @_;
 559
 560        my $res = '';
 561        my $l = '';
 562
 563        my $qlen = 0;
 564        my $off = 0;
 565        my $c;
 566
 567        # Always copy over the diff marker.
 568        $res = substr($line, 0, 1);
 569
 570        for ($off = 1; $off < length($line); $off++) {
 571                $c = substr($line, $off, 1);
 572
 573                # Comments we are wacking completly including the begin
 574                # and end, all to $;.
 575                if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
 576                        $sanitise_quote = '*/';
 577
 578                        substr($res, $off, 2, "$;$;");
 579                        $off++;
 580                        next;
 581                }
 582                if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
 583                        $sanitise_quote = '';
 584                        substr($res, $off, 2, "$;$;");
 585                        $off++;
 586                        next;
 587                }
 588                if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
 589                        $sanitise_quote = '//';
 590
 591                        substr($res, $off, 2, $sanitise_quote);
 592                        $off++;
 593                        next;
 594                }
 595
 596                # A \ in a string means ignore the next character.
 597                if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
 598                    $c eq "\\") {
 599                        substr($res, $off, 2, 'XX');
 600                        $off++;
 601                        next;
 602                }
 603                # Regular quotes.
 604                if ($c eq "'" || $c eq '"') {
 605                        if ($sanitise_quote eq '') {
 606                                $sanitise_quote = $c;
 607
 608                                substr($res, $off, 1, $c);
 609                                next;
 610                        } elsif ($sanitise_quote eq $c) {
 611                                $sanitise_quote = '';
 612                        }
 613                }
 614
 615                #print "c<$c> SQ<$sanitise_quote>\n";
 616                if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
 617                        substr($res, $off, 1, $;);
 618                } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
 619                        substr($res, $off, 1, $;);
 620                } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
 621                        substr($res, $off, 1, 'X');
 622                } else {
 623                        substr($res, $off, 1, $c);
 624                }
 625        }
 626
 627        if ($sanitise_quote eq '//') {
 628                $sanitise_quote = '';
 629        }
 630
 631        # The pathname on a #include may be surrounded by '<' and '>'.
 632        if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
 633                my $clean = 'X' x length($1);
 634                $res =~ s@\<.*\>@<$clean>@;
 635
 636        # The whole of a #error is a string.
 637        } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
 638                my $clean = 'X' x length($1);
 639                $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
 640        }
 641
 642        return $res;
 643}
 644
 645sub ctx_statement_block {
 646        my ($linenr, $remain, $off) = @_;
 647        my $line = $linenr - 1;
 648        my $blk = '';
 649        my $soff = $off;
 650        my $coff = $off - 1;
 651        my $coff_set = 0;
 652
 653        my $loff = 0;
 654
 655        my $type = '';
 656        my $level = 0;
 657        my @stack = ();
 658        my $p;
 659        my $c;
 660        my $len = 0;
 661
 662        my $remainder;
 663        while (1) {
 664                @stack = (['', 0]) if ($#stack == -1);
 665
 666                #warn "CSB: blk<$blk> remain<$remain>\n";
 667                # If we are about to drop off the end, pull in more
 668                # context.
 669                if ($off >= $len) {
 670                        for (; $remain > 0; $line++) {
 671                                last if (!defined $lines[$line]);
 672                                next if ($lines[$line] =~ /^-/);
 673                                $remain--;
 674                                $loff = $len;
 675                                $blk .= $lines[$line] . "\n";
 676                                $len = length($blk);
 677                                $line++;
 678                                last;
 679                        }
 680                        # Bail if there is no further context.
 681                        #warn "CSB: blk<$blk> off<$off> len<$len>\n";
 682                        if ($off >= $len) {
 683                                last;
 684                        }
 685                        if ($level == 0 && substr($blk, $off) =~ /^.\s*#\s*define/) {
 686                                $level++;
 687                                $type = '#';
 688                        }
 689                }
 690                $p = $c;
 691                $c = substr($blk, $off, 1);
 692                $remainder = substr($blk, $off);
 693
 694                #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
 695
 696                # Handle nested #if/#else.
 697                if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
 698                        push(@stack, [ $type, $level ]);
 699                } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
 700                        ($type, $level) = @{$stack[$#stack - 1]};
 701                } elsif ($remainder =~ /^#\s*endif\b/) {
 702                        ($type, $level) = @{pop(@stack)};
 703                }
 704
 705                # Statement ends at the ';' or a close '}' at the
 706                # outermost level.
 707                if ($level == 0 && $c eq ';') {
 708                        last;
 709                }
 710
 711                # An else is really a conditional as long as its not else if
 712                if ($level == 0 && $coff_set == 0 &&
 713                                (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
 714                                $remainder =~ /^(else)(?:\s|{)/ &&
 715                                $remainder !~ /^else\s+if\b/) {
 716                        $coff = $off + length($1) - 1;
 717                        $coff_set = 1;
 718                        #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
 719                        #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
 720                }
 721
 722                if (($type eq '' || $type eq '(') && $c eq '(') {
 723                        $level++;
 724                        $type = '(';
 725                }
 726                if ($type eq '(' && $c eq ')') {
 727                        $level--;
 728                        $type = ($level != 0)? '(' : '';
 729
 730                        if ($level == 0 && $coff < $soff) {
 731                                $coff = $off;
 732                                $coff_set = 1;
 733                                #warn "CSB: mark coff<$coff>\n";
 734                        }
 735                }
 736                if (($type eq '' || $type eq '{') && $c eq '{') {
 737                        $level++;
 738                        $type = '{';
 739                }
 740                if ($type eq '{' && $c eq '}') {
 741                        $level--;
 742                        $type = ($level != 0)? '{' : '';
 743
 744                        if ($level == 0) {
 745                                if (substr($blk, $off + 1, 1) eq ';') {
 746                                        $off++;
 747                                }
 748                                last;
 749                        }
 750                }
 751                # Preprocessor commands end at the newline unless escaped.
 752                if ($type eq '#' && $c eq "\n" && $p ne "\\") {
 753                        $level--;
 754                        $type = '';
 755                        $off++;
 756                        last;
 757                }
 758                $off++;
 759        }
 760        # We are truly at the end, so shuffle to the next line.
 761        if ($off == $len) {
 762                $loff = $len + 1;
 763                $line++;
 764                $remain--;
 765        }
 766
 767        my $statement = substr($blk, $soff, $off - $soff + 1);
 768        my $condition = substr($blk, $soff, $coff - $soff + 1);
 769
 770        #warn "STATEMENT<$statement>\n";
 771        #warn "CONDITION<$condition>\n";
 772
 773        #print "coff<$coff> soff<$off> loff<$loff>\n";
 774
 775        return ($statement, $condition,
 776                        $line, $remain + 1, $off - $loff + 1, $level);
 777}
 778
 779sub statement_lines {
 780        my ($stmt) = @_;
 781
 782        # Strip the diff line prefixes and rip blank lines at start and end.
 783        $stmt =~ s/(^|\n)./$1/g;
 784        $stmt =~ s/^\s*//;
 785        $stmt =~ s/\s*$//;
 786
 787        my @stmt_lines = ($stmt =~ /\n/g);
 788
 789        return $#stmt_lines + 2;
 790}
 791
 792sub statement_rawlines {
 793        my ($stmt) = @_;
 794
 795        my @stmt_lines = ($stmt =~ /\n/g);
 796
 797        return $#stmt_lines + 2;
 798}
 799
 800sub statement_block_size {
 801        my ($stmt) = @_;
 802
 803        $stmt =~ s/(^|\n)./$1/g;
 804        $stmt =~ s/^\s*{//;
 805        $stmt =~ s/}\s*$//;
 806        $stmt =~ s/^\s*//;
 807        $stmt =~ s/\s*$//;
 808
 809        my @stmt_lines = ($stmt =~ /\n/g);
 810        my @stmt_statements = ($stmt =~ /;/g);
 811
 812        my $stmt_lines = $#stmt_lines + 2;
 813        my $stmt_statements = $#stmt_statements + 1;
 814
 815        if ($stmt_lines > $stmt_statements) {
 816                return $stmt_lines;
 817        } else {
 818                return $stmt_statements;
 819        }
 820}
 821
 822sub ctx_statement_full {
 823        my ($linenr, $remain, $off) = @_;
 824        my ($statement, $condition, $level);
 825
 826        my (@chunks);
 827
 828        # Grab the first conditional/block pair.
 829        ($statement, $condition, $linenr, $remain, $off, $level) =
 830                                ctx_statement_block($linenr, $remain, $off);
 831        #print "F: c<$condition> s<$statement> remain<$remain>\n";
 832        push(@chunks, [ $condition, $statement ]);
 833        if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
 834                return ($level, $linenr, @chunks);
 835        }
 836
 837        # Pull in the following conditional/block pairs and see if they
 838        # could continue the statement.
 839        for (;;) {
 840                ($statement, $condition, $linenr, $remain, $off, $level) =
 841                                ctx_statement_block($linenr, $remain, $off);
 842                #print "C: c<$condition> s<$statement> remain<$remain>\n";
 843                last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
 844                #print "C: push\n";
 845                push(@chunks, [ $condition, $statement ]);
 846        }
 847
 848        return ($level, $linenr, @chunks);
 849}
 850
 851sub ctx_block_get {
 852        my ($linenr, $remain, $outer, $open, $close, $off) = @_;
 853        my $line;
 854        my $start = $linenr - 1;
 855        my $blk = '';
 856        my @o;
 857        my @c;
 858        my @res = ();
 859
 860        my $level = 0;
 861        my @stack = ($level);
 862        for ($line = $start; $remain > 0; $line++) {
 863                next if ($rawlines[$line] =~ /^-/);
 864                $remain--;
 865
 866                $blk .= $rawlines[$line];
 867
 868                # Handle nested #if/#else.
 869                if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
 870                        push(@stack, $level);
 871                } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
 872                        $level = $stack[$#stack - 1];
 873                } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
 874                        $level = pop(@stack);
 875                }
 876
 877                foreach my $c (split(//, $lines[$line])) {
 878                        ##print "C<$c>L<$level><$open$close>O<$off>\n";
 879                        if ($off > 0) {
 880                                $off--;
 881                                next;
 882                        }
 883
 884                        if ($c eq $close && $level > 0) {
 885                                $level--;
 886                                last if ($level == 0);
 887                        } elsif ($c eq $open) {
 888                                $level++;
 889                        }
 890                }
 891
 892                if (!$outer || $level <= 1) {
 893                        push(@res, $rawlines[$line]);
 894                }
 895
 896                last if ($level == 0);
 897        }
 898
 899        return ($level, @res);
 900}
 901sub ctx_block_outer {
 902        my ($linenr, $remain) = @_;
 903
 904        my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
 905        return @r;
 906}
 907sub ctx_block {
 908        my ($linenr, $remain) = @_;
 909
 910        my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
 911        return @r;
 912}
 913sub ctx_statement {
 914        my ($linenr, $remain, $off) = @_;
 915
 916        my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
 917        return @r;
 918}
 919sub ctx_block_level {
 920        my ($linenr, $remain) = @_;
 921
 922        return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
 923}
 924sub ctx_statement_level {
 925        my ($linenr, $remain, $off) = @_;
 926
 927        return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
 928}
 929
 930sub ctx_locate_comment {
 931        my ($first_line, $end_line) = @_;
 932
 933        # Catch a comment on the end of the line itself.
 934        my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
 935        return $current_comment if (defined $current_comment);
 936
 937        # Look through the context and try and figure out if there is a
 938        # comment.
 939        my $in_comment = 0;
 940        $current_comment = '';
 941        for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
 942                my $line = $rawlines[$linenr - 1];
 943                #warn "           $line\n";
 944                if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
 945                        $in_comment = 1;
 946                }
 947                if ($line =~ m@/\*@) {
 948                        $in_comment = 1;
 949                }
 950                if (!$in_comment && $current_comment ne '') {
 951                        $current_comment = '';
 952                }
 953                $current_comment .= $line . "\n" if ($in_comment);
 954                if ($line =~ m@\*/@) {
 955                        $in_comment = 0;
 956                }
 957        }
 958
 959        chomp($current_comment);
 960        return($current_comment);
 961}
 962sub ctx_has_comment {
 963        my ($first_line, $end_line) = @_;
 964        my $cmt = ctx_locate_comment($first_line, $end_line);
 965
 966        ##print "LINE: $rawlines[$end_line - 1 ]\n";
 967        ##print "CMMT: $cmt\n";
 968
 969        return ($cmt ne '');
 970}
 971
 972sub raw_line {
 973        my ($linenr, $cnt) = @_;
 974
 975        my $offset = $linenr - 1;
 976        $cnt++;
 977
 978        my $line;
 979        while ($cnt) {
 980                $line = $rawlines[$offset++];
 981                next if (defined($line) && $line =~ /^-/);
 982                $cnt--;
 983        }
 984
 985        return $line;
 986}
 987
 988sub cat_vet {
 989        my ($vet) = @_;
 990        my ($res, $coded);
 991
 992        $res = '';
 993        while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
 994                $res .= $1;
 995                if ($2 ne '') {
 996                        $coded = sprintf("^%c", unpack('C', $2) + 64);
 997                        $res .= $coded;
 998                }
 999        }
1000        $res =~ s/$/\$/;
1001
1002        return $res;
1003}
1004
1005my $av_preprocessor = 0;
1006my $av_pending;
1007my @av_paren_type;
1008my $av_pend_colon;
1009
1010sub annotate_reset {
1011        $av_preprocessor = 0;
1012        $av_pending = '_';
1013        @av_paren_type = ('E');
1014        $av_pend_colon = 'O';
1015}
1016
1017sub annotate_values {
1018        my ($stream, $type) = @_;
1019
1020        my $res;
1021        my $var = '_' x length($stream);
1022        my $cur = $stream;
1023
1024        print "$stream\n" if ($dbg_values > 1);
1025
1026        while (length($cur)) {
1027                @av_paren_type = ('E') if ($#av_paren_type < 0);
1028                print " <" . join('', @av_paren_type) .
1029                                "> <$type> <$av_pending>" if ($dbg_values > 1);
1030                if ($cur =~ /^(\s+)/o) {
1031                        print "WS($1)\n" if ($dbg_values > 1);
1032                        if ($1 =~ /\n/ && $av_preprocessor) {
1033                                $type = pop(@av_paren_type);
1034                                $av_preprocessor = 0;
1035                        }
1036
1037                } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
1038                        print "CAST($1)\n" if ($dbg_values > 1);
1039                        push(@av_paren_type, $type);
1040                        $type = 'c';
1041
1042                } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
1043                        print "DECLARE($1)\n" if ($dbg_values > 1);
1044                        $type = 'T';
1045
1046                } elsif ($cur =~ /^($Modifier)\s*/) {
1047                        print "MODIFIER($1)\n" if ($dbg_values > 1);
1048                        $type = 'T';
1049
1050                } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
1051                        print "DEFINE($1,$2)\n" if ($dbg_values > 1);
1052                        $av_preprocessor = 1;
1053                        push(@av_paren_type, $type);
1054                        if ($2 ne '') {
1055                                $av_pending = 'N';
1056                        }
1057                        $type = 'E';
1058
1059                } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
1060                        print "UNDEF($1)\n" if ($dbg_values > 1);
1061                        $av_preprocessor = 1;
1062                        push(@av_paren_type, $type);
1063
1064                } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
1065                        print "PRE_START($1)\n" if ($dbg_values > 1);
1066                        $av_preprocessor = 1;
1067
1068                        push(@av_paren_type, $type);
1069                        push(@av_paren_type, $type);
1070                        $type = 'E';
1071
1072                } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
1073                        print "PRE_RESTART($1)\n" if ($dbg_values > 1);
1074                        $av_preprocessor = 1;
1075
1076                        push(@av_paren_type, $av_paren_type[$#av_paren_type]);
1077
1078                        $type = 'E';
1079
1080                } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
1081                        print "PRE_END($1)\n" if ($dbg_values > 1);
1082
1083                        $av_preprocessor = 1;
1084
1085                        # Assume all arms of the conditional end as this
1086                        # one does, and continue as if the #endif was not here.
1087                        pop(@av_paren_type);
1088                        push(@av_paren_type, $type);
1089                        $type = 'E';
1090
1091                } elsif ($cur =~ /^(\\\n)/o) {
1092                        print "PRECONT($1)\n" if ($dbg_values > 1);
1093
1094                } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
1095                        print "ATTR($1)\n" if ($dbg_values > 1);
1096                        $av_pending = $type;
1097                        $type = 'N';
1098
1099                } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
1100                        print "SIZEOF($1)\n" if ($dbg_values > 1);
1101                        if (defined $2) {
1102                                $av_pending = 'V';
1103                        }
1104                        $type = 'N';
1105
1106                } elsif ($cur =~ /^(if|while|for)\b/o) {
1107                        print "COND($1)\n" if ($dbg_values > 1);
1108                        $av_pending = 'E';
1109                        $type = 'N';
1110
1111                } elsif ($cur =~/^(case)/o) {
1112                        print "CASE($1)\n" if ($dbg_values > 1);
1113                        $av_pend_colon = 'C';
1114                        $type = 'N';
1115
1116                } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
1117                        print "KEYWORD($1)\n" if ($dbg_values > 1);
1118                        $type = 'N';
1119
1120                } elsif ($cur =~ /^(\()/o) {
1121                        print "PAREN('$1')\n" if ($dbg_values > 1);
1122                        push(@av_paren_type, $av_pending);
1123                        $av_pending = '_';
1124                        $type = 'N';
1125
1126                } elsif ($cur =~ /^(\))/o) {
1127                        my $new_type = pop(@av_paren_type);
1128                        if ($new_type ne '_') {
1129                                $type = $new_type;
1130                                print "PAREN('$1') -> $type\n"
1131                                                        if ($dbg_values > 1);
1132                        } else {
1133                                print "PAREN('$1')\n" if ($dbg_values > 1);
1134                        }
1135
1136                } elsif ($cur =~ /^($Ident)\s*\(/o) {
1137                        print "FUNC($1)\n" if ($dbg_values > 1);
1138                        $type = 'V';
1139                        $av_pending = 'V';
1140
1141                } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
1142                        if (defined $2 && $type eq 'C' || $type eq 'T') {
1143                                $av_pend_colon = 'B';
1144                        } elsif ($type eq 'E') {
1145                                $av_pend_colon = 'L';
1146                        }
1147                        print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
1148                        $type = 'V';
1149
1150                } elsif ($cur =~ /^($Ident|$Constant)/o) {
1151                        print "IDENT($1)\n" if ($dbg_values > 1);
1152                        $type = 'V';
1153
1154                } elsif ($cur =~ /^($Assignment)/o) {
1155                        print "ASSIGN($1)\n" if ($dbg_values > 1);
1156                        $type = 'N';
1157
1158                } elsif ($cur =~/^(;|{|})/) {
1159                        print "END($1)\n" if ($dbg_values > 1);
1160                        $type = 'E';
1161                        $av_pend_colon = 'O';
1162
1163                } elsif ($cur =~/^(,)/) {
1164                        print "COMMA($1)\n" if ($dbg_values > 1);
1165                        $type = 'C';
1166
1167                } elsif ($cur =~ /^(\?)/o) {
1168                        print "QUESTION($1)\n" if ($dbg_values > 1);
1169                        $type = 'N';
1170
1171                } elsif ($cur =~ /^(:)/o) {
1172                        print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
1173
1174                        substr($var, length($res), 1, $av_pend_colon);
1175                        if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
1176                                $type = 'E';
1177                        } else {
1178                                $type = 'N';
1179                        }
1180                        $av_pend_colon = 'O';
1181
1182                } elsif ($cur =~ /^(\[)/o) {
1183                        print "CLOSE($1)\n" if ($dbg_values > 1);
1184                        $type = 'N';
1185
1186                } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1187                        my $variant;
1188
1189                        print "OPV($1)\n" if ($dbg_values > 1);
1190                        if ($type eq 'V') {
1191                                $variant = 'B';
1192                        } else {
1193                                $variant = 'U';
1194                        }
1195
1196                        substr($var, length($res), 1, $variant);
1197                        $type = 'N';
1198
1199                } elsif ($cur =~ /^($Operators)/o) {
1200                        print "OP($1)\n" if ($dbg_values > 1);
1201                        if ($1 ne '++' && $1 ne '--') {
1202                                $type = 'N';
1203                        }
1204
1205                } elsif ($cur =~ /(^.)/o) {
1206                        print "C($1)\n" if ($dbg_values > 1);
1207                }
1208                if (defined $1) {
1209                        $cur = substr($cur, length($1));
1210                        $res .= $type x length($1);
1211                }
1212        }
1213
1214        return ($res, $var);
1215}
1216
1217sub possible {
1218        my ($possible, $line) = @_;
1219        my $notPermitted = qr{(?:
1220                ^(?:
1221                        $Modifier|
1222                        $Storage|
1223                        $Type|
1224                        DEFINE_\S+
1225                )$|
1226                ^(?:
1227                        goto|
1228                        return|
1229                        case|
1230                        else|
1231                        asm|__asm__|
1232                        do|
1233                        \#|
1234                        \#\#|
1235                )(?:\s|$)|
1236                ^(?:typedef|struct|enum)\b
1237            )}x;
1238        warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1239        if ($possible !~ $notPermitted) {
1240                # Check for modifiers.
1241                $possible =~ s/\s*$Storage\s*//g;
1242                $possible =~ s/\s*$Sparse\s*//g;
1243                if ($possible =~ /^\s*$/) {
1244
1245                } elsif ($possible =~ /\s/) {
1246                        $possible =~ s/\s*$Type\s*//g;
1247                        for my $modifier (split(' ', $possible)) {
1248                                if ($modifier !~ $notPermitted) {
1249                                        warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1250                                        push(@modifierList, $modifier);
1251                                }
1252                        }
1253
1254                } else {
1255                        warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1256                        push(@typeList, $possible);
1257                }
1258                build_types();
1259        } else {
1260                warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
1261        }
1262}
1263
1264my $prefix = '';
1265
1266sub show_type {
1267       return !defined $ignore_type{$_[0]};
1268}
1269
1270sub report {
1271        if (!show_type($_[1]) ||
1272            (defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) {
1273                return 0;
1274        }
1275        my $line;
1276        if ($show_types) {
1277                $line = "$prefix$_[0]:$_[1]: $_[2]\n";
1278        } else {
1279                $line = "$prefix$_[0]: $_[2]\n";
1280        }
1281        $line = (split('\n', $line))[0] . "\n" if ($terse);
1282
1283        push(our @report, $line);
1284
1285        return 1;
1286}
1287sub report_dump {
1288        our @report;
1289}
1290
1291sub ERROR {
1292        if (report("ERROR", $_[0], $_[1])) {
1293                our $clean = 0;
1294                our $cnt_error++;
1295        }
1296}
1297sub WARN {
1298        if (report("WARNING", $_[0], $_[1])) {
1299                our $clean = 0;
1300                our $cnt_warn++;
1301        }
1302}
1303sub CHK {
1304        if ($check && report("CHECK", $_[0], $_[1])) {
1305                our $clean = 0;
1306                our $cnt_chk++;
1307        }
1308}
1309
1310sub check_absolute_file {
1311        my ($absolute, $herecurr) = @_;
1312        my $file = $absolute;
1313
1314        ##print "absolute<$absolute>\n";
1315
1316        # See if any suffix of this path is a path within the tree.
1317        while ($file =~ s@^[^/]*/@@) {
1318                if (-f "$root/$file") {
1319                        ##print "file<$file>\n";
1320                        last;
1321                }
1322        }
1323        if (! -f _)  {
1324                return 0;
1325        }
1326
1327        # It is, so see if the prefix is acceptable.
1328        my $prefix = $absolute;
1329        substr($prefix, -length($file)) = '';
1330
1331        ##print "prefix<$prefix>\n";
1332        if ($prefix ne ".../") {
1333                WARN("USE_RELATIVE_PATH",
1334                     "use relative pathname instead of absolute in changelog text\n" . $herecurr);
1335        }
1336}
1337
1338sub pos_last_openparen {
1339        my ($line) = @_;
1340
1341        my $pos = 0;
1342
1343        my $opens = $line =~ tr/\(/\(/;
1344        my $closes = $line =~ tr/\)/\)/;
1345
1346        my $last_openparen = 0;
1347
1348        if (($opens == 0) || ($closes >= $opens)) {
1349                return -1;
1350        }
1351
1352        my $len = length($line);
1353
1354        for ($pos = 0; $pos < $len; $pos++) {
1355                my $string = substr($line, $pos);
1356                if ($string =~ /^($FuncArg|$balanced_parens)/) {
1357                        $pos += length($1) - 1;
1358                } elsif (substr($line, $pos, 1) eq '(') {
1359                        $last_openparen = $pos;
1360                } elsif (index($string, '(') == -1) {
1361                        last;
1362                }
1363        }
1364
1365        return $last_openparen + 1;
1366}
1367
1368sub process {
1369        my $filename = shift;
1370
1371        my $linenr=0;
1372        my $prevline="";
1373        my $prevrawline="";
1374        my $stashline="";
1375        my $stashrawline="";
1376
1377        my $length;
1378        my $indent;
1379        my $previndent=0;
1380        my $stashindent=0;
1381
1382        our $clean = 1;
1383        my $signoff = 0;
1384        my $is_patch = 0;
1385
1386        my $in_header_lines = 1;
1387        my $in_commit_log = 0;          #Scanning lines before patch
1388
1389        my $non_utf8_charset = 0;
1390
1391        our @report = ();
1392        our $cnt_lines = 0;
1393        our $cnt_error = 0;
1394        our $cnt_warn = 0;
1395        our $cnt_chk = 0;
1396
1397        # Trace the real file/line as we go.
1398        my $realfile = '';
1399        my $realline = 0;
1400        my $realcnt = 0;
1401        my $here = '';
1402        my $in_comment = 0;
1403        my $comment_edge = 0;
1404        my $first_line = 0;
1405        my $p1_prefix = '';
1406
1407        my $prev_values = 'E';
1408
1409        # suppression flags
1410        my %suppress_ifbraces;
1411        my %suppress_whiletrailers;
1412        my %suppress_export;
1413        my $suppress_statement = 0;
1414
1415        # Pre-scan the patch sanitizing the lines.
1416        # Pre-scan the patch looking for any __setup documentation.
1417        #
1418        my @setup_docs = ();
1419        my $setup_docs = 0;
1420
1421        sanitise_line_reset();
1422        my $line;
1423        foreach my $rawline (@rawlines) {
1424                $linenr++;
1425                $line = $rawline;
1426
1427                if ($rawline=~/^\+\+\+\s+(\S+)/) {
1428                        $setup_docs = 0;
1429                        if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1430                                $setup_docs = 1;
1431                        }
1432                        #next;
1433                }
1434                if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1435                        $realline=$1-1;
1436                        if (defined $2) {
1437                                $realcnt=$3+1;
1438                        } else {
1439                                $realcnt=1+1;
1440                        }
1441                        $in_comment = 0;
1442
1443                        # Guestimate if this is a continuing comment.  Run
1444                        # the context looking for a comment "edge".  If this
1445                        # edge is a close comment then we must be in a comment
1446                        # at context start.
1447                        my $edge;
1448                        my $cnt = $realcnt;
1449                        for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1450                                next if (defined $rawlines[$ln - 1] &&
1451                                         $rawlines[$ln - 1] =~ /^-/);
1452                                $cnt--;
1453                                #print "RAW<$rawlines[$ln - 1]>\n";
1454                                last if (!defined $rawlines[$ln - 1]);
1455                                if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1456                                    $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1457                                        ($edge) = $1;
1458                                        last;
1459                                }
1460                        }
1461                        if (defined $edge && $edge eq '*/') {
1462                                $in_comment = 1;
1463                        }
1464
1465                        # Guestimate if this is a continuing comment.  If this
1466                        # is the start of a diff block and this line starts
1467                        # ' *' then it is very likely a comment.
1468                        if (!defined $edge &&
1469                            $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
1470                        {
1471                                $in_comment = 1;
1472                        }
1473
1474                        ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1475                        sanitise_line_reset($in_comment);
1476
1477                } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1478                        # Standardise the strings and chars within the input to
1479                        # simplify matching -- only bother with positive lines.
1480                        $line = sanitise_line($rawline);
1481                }
1482                push(@lines, $line);
1483
1484                if ($realcnt > 1) {
1485                        $realcnt-- if ($line =~ /^(?:\+| |$)/);
1486                } else {
1487                        $realcnt = 0;
1488                }
1489
1490                #print "==>$rawline\n";
1491                #print "-->$line\n";
1492
1493                if ($setup_docs && $line =~ /^\+/) {
1494                        push(@setup_docs, $line);
1495                }
1496        }
1497
1498        $prefix = '';
1499
1500        $realcnt = 0;
1501        $linenr = 0;
1502        foreach my $line (@lines) {
1503                $linenr++;
1504
1505                my $rawline = $rawlines[$linenr - 1];
1506
1507#extract the line range in the file after the patch is applied
1508                if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1509                        $is_patch = 1;
1510                        $first_line = $linenr + 1;
1511                        $realline=$1-1;
1512                        if (defined $2) {
1513                                $realcnt=$3+1;
1514                        } else {
1515                                $realcnt=1+1;
1516                        }
1517                        annotate_reset();
1518                        $prev_values = 'E';
1519
1520                        %suppress_ifbraces = ();
1521                        %suppress_whiletrailers = ();
1522                        %suppress_export = ();
1523                        $suppress_statement = 0;
1524                        next;
1525
1526# track the line number as we move through the hunk, note that
1527# new versions of GNU diff omit the leading space on completely
1528# blank context lines so we need to count that too.
1529                } elsif ($line =~ /^( |\+|$)/) {
1530                        $realline++;
1531                        $realcnt-- if ($realcnt != 0);
1532
1533                        # Measure the line length and indent.
1534                        ($length, $indent) = line_stats($rawline);
1535
1536                        # Track the previous line.
1537                        ($prevline, $stashline) = ($stashline, $line);
1538                        ($previndent, $stashindent) = ($stashindent, $indent);
1539                        ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1540
1541                        #warn "line<$line>\n";
1542
1543                } elsif ($realcnt == 1) {
1544                        $realcnt--;
1545                }
1546
1547                my $hunk_line = ($realcnt != 0);
1548
1549#make up the handle for any error we report on this line
1550                $prefix = "$filename:$realline: " if ($emacs && $file);
1551                $prefix = "$filename:$linenr: " if ($emacs && !$file);
1552
1553                $here = "#$linenr: " if (!$file);
1554                $here = "#$realline: " if ($file);
1555
1556                # extract the filename as it passes
1557                if ($line =~ /^diff --git.*?(\S+)$/) {
1558                        $realfile = $1;
1559                        $realfile =~ s@^([^/]*)/@@;
1560                        $in_commit_log = 0;
1561                } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
1562                        $realfile = $1;
1563                        $realfile =~ s@^([^/]*)/@@;
1564                        $in_commit_log = 0;
1565
1566                        $p1_prefix = $1;
1567                        if (!$file && $tree && $p1_prefix ne '' &&
1568                            -e "$root/$p1_prefix") {
1569                                WARN("PATCH_PREFIX",
1570                                     "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
1571                        }
1572
1573                        if ($realfile =~ m@^include/asm/@) {
1574                                ERROR("MODIFIED_INCLUDE_ASM",
1575                                      "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1576                        }
1577                        next;
1578                }
1579
1580                $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1581
1582                my $hereline = "$here\n$rawline\n";
1583                my $herecurr = "$here\n$rawline\n";
1584                my $hereprev = "$here\n$prevrawline\n$rawline\n";
1585
1586                $cnt_lines++ if ($realcnt != 0);
1587
1588# Check for incorrect file permissions
1589                if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
1590                        my $permhere = $here . "FILE: $realfile\n";
1591                        if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
1592                                ERROR("EXECUTE_PERMISSIONS",
1593                                      "do not set execute permissions for source files\n" . $permhere);
1594                        }
1595                }
1596
1597# Check the patch for a signoff:
1598                if ($line =~ /^\s*signed-off-by:/i) {
1599                        $signoff++;
1600                        $in_commit_log = 0;
1601                }
1602
1603# Check signature styles
1604                if (!$in_header_lines &&
1605                    $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
1606                        my $space_before = $1;
1607                        my $sign_off = $2;
1608                        my $space_after = $3;
1609                        my $email = $4;
1610                        my $ucfirst_sign_off = ucfirst(lc($sign_off));
1611
1612                        if ($sign_off !~ /$signature_tags/) {
1613                                WARN("BAD_SIGN_OFF",
1614                                     "Non-standard signature: $sign_off\n" . $herecurr);
1615                        }
1616                        if (defined $space_before && $space_before ne "") {
1617                                WARN("BAD_SIGN_OFF",
1618                                     "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
1619                        }
1620                        if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
1621                                WARN("BAD_SIGN_OFF",
1622                                     "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
1623                        }
1624                        if (!defined $space_after || $space_after ne " ") {
1625                                WARN("BAD_SIGN_OFF",
1626                                     "Use a single space after $ucfirst_sign_off\n" . $herecurr);
1627                        }
1628
1629                        my ($email_name, $email_address, $comment) = parse_email($email);
1630                        my $suggested_email = format_email(($email_name, $email_address));
1631                        if ($suggested_email eq "") {
1632                                ERROR("BAD_SIGN_OFF",
1633                                      "Unrecognized email address: '$email'\n" . $herecurr);
1634                        } else {
1635                                my $dequoted = $suggested_email;
1636                                $dequoted =~ s/^"//;
1637                                $dequoted =~ s/" </ </;
1638                                # Don't force email to have quotes
1639                                # Allow just an angle bracketed address
1640                                if ("$dequoted$comment" ne $email &&
1641                                    "<$email_address>$comment" ne $email &&
1642                                    "$suggested_email$comment" ne $email) {
1643                                        WARN("BAD_SIGN_OFF",
1644                                             "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
1645                                }
1646                        }
1647                }
1648
1649# Check for wrappage within a valid hunk of the file
1650                if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1651                        ERROR("CORRUPTED_PATCH",
1652                              "patch seems to be corrupt (line wrapped?)\n" .
1653                                $herecurr) if (!$emitted_corrupt++);
1654                }
1655
1656# Check for absolute kernel paths.
1657                if ($tree) {
1658                        while ($line =~ m{(?:^|\s)(/\S*)}g) {
1659                                my $file = $1;
1660
1661                                if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1662                                    check_absolute_file($1, $herecurr)) {
1663                                        #
1664                                } else {
1665                                        check_absolute_file($file, $herecurr);
1666                                }
1667                        }
1668                }
1669
1670# UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1671                if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1672                    $rawline !~ m/^$UTF8*$/) {
1673                        my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1674
1675                        my $blank = copy_spacing($rawline);
1676                        my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1677                        my $hereptr = "$hereline$ptr\n";
1678
1679                        CHK("INVALID_UTF8",
1680                            "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1681                }
1682
1683# Check if it's the start of a commit log
1684# (not a header line and we haven't seen the patch filename)
1685                if ($in_header_lines && $realfile =~ /^$/ &&
1686                    $rawline !~ /^(commit\b|from\b|[\w-]+:).+$/i) {
1687                        $in_header_lines = 0;
1688                        $in_commit_log = 1;
1689                }
1690
1691# Check if there is UTF-8 in a commit log when a mail header has explicitly
1692# declined it, i.e defined some charset where it is missing.
1693                if ($in_header_lines &&
1694                    $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
1695                    $1 !~ /utf-8/i) {
1696                        $non_utf8_charset = 1;
1697                }
1698
1699                if ($in_commit_log && $non_utf8_charset && $realfile =~ /^$/ &&
1700                    $rawline =~ /$NON_ASCII_UTF8/) {
1701                        WARN("UTF8_BEFORE_PATCH",
1702                            "8-bit UTF-8 used in possible commit log\n" . $herecurr);
1703                }
1704
1705# ignore non-hunk lines and lines being removed
1706                next if (!$hunk_line || $line =~ /^-/);
1707
1708#trailing whitespace
1709                if ($line =~ /^\+.*\015/) {
1710                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1711                        ERROR("DOS_LINE_ENDINGS",
1712                              "DOS line endings\n" . $herevet);
1713
1714                } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1715                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1716                        ERROR("TRAILING_WHITESPACE",
1717                              "trailing whitespace\n" . $herevet);
1718                        $rpt_cleaners = 1;
1719                }
1720
1721# check for Kconfig help text having a real description
1722# Only applies when adding the entry originally, after that we do not have
1723# sufficient context to determine whether it is indeed long enough.
1724                if ($realfile =~ /Kconfig/ &&
1725                    $line =~ /.\s*config\s+/) {
1726                        my $length = 0;
1727                        my $cnt = $realcnt;
1728                        my $ln = $linenr + 1;
1729                        my $f;
1730                        my $is_start = 0;
1731                        my $is_end = 0;
1732                        for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
1733                                $f = $lines[$ln - 1];
1734                                $cnt-- if ($lines[$ln - 1] !~ /^-/);
1735                                $is_end = $lines[$ln - 1] =~ /^\+/;
1736
1737                                next if ($f =~ /^-/);
1738
1739                                if ($lines[$ln - 1] =~ /.\s*(?:bool|tristate)\s*\"/) {
1740                                        $is_start = 1;
1741                                } elsif ($lines[$ln - 1] =~ /.\s*(?:---)?help(?:---)?$/) {
1742                                        $length = -1;
1743                                }
1744
1745                                $f =~ s/^.//;
1746                                $f =~ s/#.*//;
1747                                $f =~ s/^\s+//;
1748                                next if ($f =~ /^$/);
1749                                if ($f =~ /^\s*config\s/) {
1750                                        $is_end = 1;
1751                                        last;
1752                                }
1753                                $length++;
1754                        }
1755                        WARN("CONFIG_DESCRIPTION",
1756                             "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
1757                        #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
1758                }
1759
1760                if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
1761                    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
1762                        my $flag = $1;
1763                        my $replacement = {
1764                                'EXTRA_AFLAGS' =>   'asflags-y',
1765                                'EXTRA_CFLAGS' =>   'ccflags-y',
1766                                'EXTRA_CPPFLAGS' => 'cppflags-y',
1767                                'EXTRA_LDFLAGS' =>  'ldflags-y',
1768                        };
1769
1770                        WARN("DEPRECATED_VARIABLE",
1771                             "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
1772                }
1773
1774# check we are in a valid source file if not then ignore this hunk
1775                next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1776
1777#80 column limit
1778                if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1779                    $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1780                    !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
1781                    $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
1782                    $length > 80)
1783                {
1784                        WARN("LONG_LINE",
1785                             "line over 80 characters\n" . $herecurr);
1786                }
1787
1788# Check for user-visible strings broken across lines, which breaks the ability
1789# to grep for the string.  Limited to strings used as parameters (those
1790# following an open parenthesis), which almost completely eliminates false
1791# positives, as well as warning only once per parameter rather than once per
1792# line of the string.  Make an exception when the previous string ends in a
1793# newline (multiple lines in one string constant) or \n\t (common in inline
1794# assembly to indent the instruction on the following line).
1795                if ($line =~ /^\+\s*"/ &&
1796                    $prevline =~ /"\s*$/ &&
1797                    $prevline =~ /\(/ &&
1798                    $prevrawline !~ /\\n(?:\\t)*"\s*$/) {
1799                        WARN("SPLIT_STRING",
1800                             "quoted string split across lines\n" . $hereprev);
1801                }
1802
1803# check for spaces before a quoted newline
1804                if ($rawline =~ /^.*\".*\s\\n/) {
1805                        WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
1806                             "unnecessary whitespace before a quoted newline\n" . $herecurr);
1807                }
1808
1809# check for adding lines without a newline.
1810                if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1811                        WARN("MISSING_EOF_NEWLINE",
1812                             "adding a line without newline at end of file\n" . $herecurr);
1813                }
1814
1815# Blackfin: use hi/lo macros
1816                if ($realfile =~ m@arch/blackfin/.*\.S$@) {
1817                        if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
1818                                my $herevet = "$here\n" . cat_vet($line) . "\n";
1819                                ERROR("LO_MACRO",
1820                                      "use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
1821                        }
1822                        if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
1823                                my $herevet = "$here\n" . cat_vet($line) . "\n";
1824                                ERROR("HI_MACRO",
1825                                      "use the HI() macro, not (... >> 16)\n" . $herevet);
1826                        }
1827                }
1828
1829# check we are in a valid source file C or perl if not then ignore this hunk
1830                next if ($realfile !~ /\.(h|c|pl)$/);
1831
1832# at the beginning of a line any tabs must come first and anything
1833# more than 8 must use tabs.
1834                if ($rawline =~ /^\+\s* \t\s*\S/ ||
1835                    $rawline =~ /^\+\s*        \s*/) {
1836                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1837                        ERROR("CODE_INDENT",
1838                              "code indent should use tabs where possible\n" . $herevet);
1839                        $rpt_cleaners = 1;
1840                }
1841
1842# check for space before tabs.
1843                if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
1844                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1845                        WARN("SPACE_BEFORE_TAB",
1846                             "please, no space before tabs\n" . $herevet);
1847                }
1848
1849# check for && or || at the start of a line
1850                if ($rawline =~ /^\+\s*(&&|\|\|)/) {
1851                        CHK("LOGICAL_CONTINUATIONS",
1852                            "Logical continuations should be on the previous line\n" . $hereprev);
1853                }
1854
1855# check multi-line statement indentation matches previous line
1856                if ($^V && $^V ge 5.10.0 &&
1857                    $prevline =~ /^\+(\t*)(if \(|$Ident\().*(\&\&|\|\||,)\s*$/) {
1858                        $prevline =~ /^\+(\t*)(.*)$/;
1859                        my $oldindent = $1;
1860                        my $rest = $2;
1861
1862                        my $pos = pos_last_openparen($rest);
1863                        if ($pos >= 0) {
1864                                $line =~ /^(\+| )([ \t]*)/;
1865                                my $newindent = $2;
1866
1867                                my $goodtabindent = $oldindent .
1868                                        "\t" x ($pos / 8) .
1869                                        " "  x ($pos % 8);
1870                                my $goodspaceindent = $oldindent . " "  x $pos;
1871
1872                                if ($newindent ne $goodtabindent &&
1873                                    $newindent ne $goodspaceindent) {
1874                                        CHK("PARENTHESIS_ALIGNMENT",
1875                                            "Alignment should match open parenthesis\n" . $hereprev);
1876                                }
1877                        }
1878                }
1879
1880                if ($line =~ /^\+.*\*[ \t]*\)[ \t]+/) {
1881                        CHK("SPACING",
1882                            "No space is necessary after a cast\n" . $hereprev);
1883                }
1884
1885                if ($realfile =~ m@^(drivers/net/|net/)@ &&
1886                    $rawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
1887                    $prevrawline =~ /^\+[ \t]*$/) {
1888                        WARN("NETWORKING_BLOCK_COMMENT_STYLE",
1889                             "networking block comments don't use an empty /* line, use /* Comment...\n" . $hereprev);
1890                }
1891
1892                if ($realfile =~ m@^(drivers/net/|net/)@ &&
1893                    $rawline !~ m@^\+[ \t]*\*/[ \t]*$@ &&       #trailing */
1894                    $rawline !~ m@^\+.*/\*.*\*/[ \t]*$@ &&      #inline /*...*/
1895                    $rawline !~ m@^\+.*\*{2,}/[ \t]*$@ &&       #trailing **/
1896                    $rawline =~ m@^\+[ \t]*.+\*\/[ \t]*$@) {    #non blank */
1897                        WARN("NETWORKING_BLOCK_COMMENT_STYLE",
1898                             "networking block comments put the trailing */ on a separate line\n" . $herecurr);
1899                }
1900
1901# check for spaces at the beginning of a line.
1902# Exceptions:
1903#  1) within comments
1904#  2) indented preprocessor commands
1905#  3) hanging labels
1906                if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/)  {
1907                        my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1908                        WARN("LEADING_SPACE",
1909                             "please, no spaces at the start of a line\n" . $herevet);
1910                }
1911
1912# check we are in a valid C source file if not then ignore this hunk
1913                next if ($realfile !~ /\.(h|c)$/);
1914
1915# check for RCS/CVS revision markers
1916                if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1917                        WARN("CVS_KEYWORD",
1918                             "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1919                }
1920
1921# Blackfin: don't use __builtin_bfin_[cs]sync
1922                if ($line =~ /__builtin_bfin_csync/) {
1923                        my $herevet = "$here\n" . cat_vet($line) . "\n";
1924                        ERROR("CSYNC",
1925                              "use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
1926                }
1927                if ($line =~ /__builtin_bfin_ssync/) {
1928                        my $herevet = "$here\n" . cat_vet($line) . "\n";
1929                        ERROR("SSYNC",
1930                              "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
1931                }
1932
1933# Check for potential 'bare' types
1934                my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
1935                    $realline_next);
1936#print "LINE<$line>\n";
1937                if ($linenr >= $suppress_statement &&
1938                    $realcnt && $line =~ /.\s*\S/) {
1939                        ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
1940                                ctx_statement_block($linenr, $realcnt, 0);
1941                        $stat =~ s/\n./\n /g;
1942                        $cond =~ s/\n./\n /g;
1943
1944#print "linenr<$linenr> <$stat>\n";
1945                        # If this statement has no statement boundaries within
1946                        # it there is no point in retrying a statement scan
1947                        # until we hit end of it.
1948                        my $frag = $stat; $frag =~ s/;+\s*$//;
1949                        if ($frag !~ /(?:{|;)/) {
1950#print "skip<$line_nr_next>\n";
1951                                $suppress_statement = $line_nr_next;
1952                        }
1953
1954                        # Find the real next line.
1955                        $realline_next = $line_nr_next;
1956                        if (defined $realline_next &&
1957                            (!defined $lines[$realline_next - 1] ||
1958                             substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
1959                                $realline_next++;
1960                        }
1961
1962                        my $s = $stat;
1963                        $s =~ s/{.*$//s;
1964
1965                        # Ignore goto labels.
1966                        if ($s =~ /$Ident:\*$/s) {
1967
1968                        # Ignore functions being called
1969                        } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1970
1971                        } elsif ($s =~ /^.\s*else\b/s) {
1972
1973                        # declarations always start with types
1974                        } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
1975                                my $type = $1;
1976                                $type =~ s/\s+/ /g;
1977                                possible($type, "A:" . $s);
1978
1979                        # definitions in global scope can only start with types
1980                        } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
1981                                possible($1, "B:" . $s);
1982                        }
1983
1984                        # any (foo ... *) is a pointer cast, and foo is a type
1985                        while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
1986                                possible($1, "C:" . $s);
1987                        }
1988
1989                        # Check for any sort of function declaration.
1990                        # int foo(something bar, other baz);
1991                        # void (*store_gdt)(x86_descr_ptr *);
1992                        if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1993                                my ($name_len) = length($1);
1994
1995                                my $ctx = $s;
1996                                substr($ctx, 0, $name_len + 1, '');
1997                                $ctx =~ s/\)[^\)]*$//;
1998
1999                                for my $arg (split(/\s*,\s*/, $ctx)) {
2000                                        if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
2001
2002                                                possible($1, "D:" . $s);
2003                                        }
2004                                }
2005                        }
2006
2007                }
2008
2009#
2010# Checks which may be anchored in the context.
2011#
2012
2013# Check for switch () and associated case and default
2014# statements should be at the same indent.
2015                if ($line=~/\bswitch\s*\(.*\)/) {
2016                        my $err = '';
2017                        my $sep = '';
2018                        my @ctx = ctx_block_outer($linenr, $realcnt);
2019                        shift(@ctx);
2020                        for my $ctx (@ctx) {
2021                                my ($clen, $cindent) = line_stats($ctx);
2022                                if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
2023                                                        $indent != $cindent) {
2024                                        $err .= "$sep$ctx\n";
2025                                        $sep = '';
2026                                } else {
2027                                        $sep = "[...]\n";
2028                                }
2029                        }
2030                        if ($err ne '') {
2031                                ERROR("SWITCH_CASE_INDENT_LEVEL",
2032                                      "switch and case should be at the same indent\n$hereline$err");
2033                        }
2034                }
2035
2036# if/while/etc brace do not go on next line, unless defining a do while loop,
2037# or if that brace on the next line is for something else
2038                if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
2039                        my $pre_ctx = "$1$2";
2040
2041                        my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
2042
2043                        if ($line =~ /^\+\t{6,}/) {
2044                                WARN("DEEP_INDENTATION",
2045                                     "Too many leading tabs - consider code refactoring\n" . $herecurr);
2046                        }
2047
2048                        my $ctx_cnt = $realcnt - $#ctx - 1;
2049                        my $ctx = join("\n", @ctx);
2050
2051                        my $ctx_ln = $linenr;
2052                        my $ctx_skip = $realcnt;
2053
2054                        while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
2055                                        defined $lines[$ctx_ln - 1] &&
2056                                        $lines[$ctx_ln - 1] =~ /^-/)) {
2057                                ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2058                                $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
2059                                $ctx_ln++;
2060                        }
2061
2062                        #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2063                        #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2064
2065                        if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
2066                                ERROR("OPEN_BRACE",
2067                                      "that open brace { should be on the previous line\n" .
2068                                        "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2069                        }
2070                        if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
2071                            $ctx =~ /\)\s*\;\s*$/ &&
2072                            defined $lines[$ctx_ln - 1])
2073                        {
2074                                my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
2075                                if ($nindent > $indent) {
2076                                        WARN("TRAILING_SEMICOLON",
2077                                             "trailing semicolon indicates no statements, indent implies otherwise\n" .
2078                                                "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2079                                }
2080                        }
2081                }
2082
2083# Check relative indent for conditionals and blocks.
2084                if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2085                        ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2086                                ctx_statement_block($linenr, $realcnt, 0)
2087                                        if (!defined $stat);
2088                        my ($s, $c) = ($stat, $cond);
2089
2090                        substr($s, 0, length($c), '');
2091
2092                        # Make sure we remove the line prefixes as we have
2093                        # none on the first line, and are going to readd them
2094                        # where necessary.
2095                        $s =~ s/\n./\n/gs;
2096
2097                        # Find out how long the conditional actually is.
2098                        my @newlines = ($c =~ /\n/gs);
2099                        my $cond_lines = 1 + $#newlines;
2100
2101                        # We want to check the first line inside the block
2102                        # starting at the end of the conditional, so remove:
2103                        #  1) any blank line termination
2104                        #  2) any opening brace { on end of the line
2105                        #  3) any do (...) {
2106                        my $continuation = 0;
2107                        my $check = 0;
2108                        $s =~ s/^.*\bdo\b//;
2109                        $s =~ s/^\s*{//;
2110                        if ($s =~ s/^\s*\\//) {
2111                                $continuation = 1;
2112                        }
2113                        if ($s =~ s/^\s*?\n//) {
2114                                $check = 1;
2115                                $cond_lines++;
2116                        }
2117
2118                        # Also ignore a loop construct at the end of a
2119                        # preprocessor statement.
2120                        if (($prevline =~ /^.\s*#\s*define\s/ ||
2121                            $prevline =~ /\\\s*$/) && $continuation == 0) {
2122                                $check = 0;
2123                        }
2124
2125                        my $cond_ptr = -1;
2126                        $continuation = 0;
2127                        while ($cond_ptr != $cond_lines) {
2128                                $cond_ptr = $cond_lines;
2129
2130                                # If we see an #else/#elif then the code
2131                                # is not linear.
2132                                if ($s =~ /^\s*\#\s*(?:else|elif)/) {
2133                                        $check = 0;
2134                                }
2135
2136                                # Ignore:
2137                                #  1) blank lines, they should be at 0,
2138                                #  2) preprocessor lines, and
2139                                #  3) labels.
2140                                if ($continuation ||
2141                                    $s =~ /^\s*?\n/ ||
2142                                    $s =~ /^\s*#\s*?/ ||
2143                                    $s =~ /^\s*$Ident\s*:/) {
2144                                        $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
2145                                        if ($s =~ s/^.*?\n//) {
2146                                                $cond_lines++;
2147                                        }
2148                                }
2149                        }
2150
2151                        my (undef, $sindent) = line_stats("+" . $s);
2152                        my $stat_real = raw_line($linenr, $cond_lines);
2153
2154                        # Check if either of these lines are modified, else
2155                        # this is not this patch's fault.
2156                        if (!defined($stat_real) ||
2157                            $stat !~ /^\+/ && $stat_real !~ /^\+/) {
2158                                $check = 0;
2159                        }
2160                        if (defined($stat_real) && $cond_lines > 1) {
2161                                $stat_real = "[...]\n$stat_real";
2162                        }
2163
2164                        #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2165
2166                        if ($check && (($sindent % 8) != 0 ||
2167                            ($sindent <= $indent && $s ne ''))) {
2168                                WARN("SUSPECT_CODE_INDENT",
2169                                     "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2170                        }
2171                }
2172
2173                # Track the 'values' across context and added lines.
2174                my $opline = $line; $opline =~ s/^./ /;
2175                my ($curr_values, $curr_vars) =
2176                                annotate_values($opline . "\n", $prev_values);
2177                $curr_values = $prev_values . $curr_values;
2178                if ($dbg_values) {
2179                        my $outline = $opline; $outline =~ s/\t/ /g;
2180                        print "$linenr > .$outline\n";
2181                        print "$linenr > $curr_values\n";
2182                        print "$linenr >  $curr_vars\n";
2183                }
2184                $prev_values = substr($curr_values, -1);
2185
2186#ignore lines not being added
2187                if ($line=~/^[^\+]/) {next;}
2188
2189# TEST: allow direct testing of the type matcher.
2190                if ($dbg_type) {
2191                        if ($line =~ /^.\s*$Declare\s*$/) {
2192                                ERROR("TEST_TYPE",
2193                                      "TEST: is type\n" . $herecurr);
2194                        } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
2195                                ERROR("TEST_NOT_TYPE",
2196                                      "TEST: is not type ($1 is)\n". $herecurr);
2197                        }
2198                        next;
2199                }
2200# TEST: allow direct testing of the attribute matcher.
2201                if ($dbg_attr) {
2202                        if ($line =~ /^.\s*$Modifier\s*$/) {
2203                                ERROR("TEST_ATTR",
2204                                      "TEST: is attr\n" . $herecurr);
2205                        } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
2206                                ERROR("TEST_NOT_ATTR",
2207                                      "TEST: is not attr ($1 is)\n". $herecurr);
2208                        }
2209                        next;
2210                }
2211
2212# check for initialisation to aggregates open brace on the next line
2213                if ($line =~ /^.\s*{/ &&
2214                    $prevline =~ /(?:^|[^=])=\s*$/) {
2215                        ERROR("OPEN_BRACE",
2216                              "that open brace { should be on the previous line\n" . $hereprev);
2217                }
2218
2219#
2220# Checks which are anchored on the added line.
2221#
2222
2223# check for malformed paths in #include statements (uses RAW line)
2224                if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
2225                        my $path = $1;
2226                        if ($path =~ m{//}) {
2227                                ERROR("MALFORMED_INCLUDE",
2228                                      "malformed #include filename\n" .
2229                                        $herecurr);
2230                        }
2231                }
2232
2233# no C99 // comments
2234                if ($line =~ m{//}) {
2235                        ERROR("C99_COMMENTS",
2236                              "do not use C99 // comments\n" . $herecurr);
2237                }
2238                # Remove C99 comments.
2239                $line =~ s@//.*@@;
2240                $opline =~ s@//.*@@;
2241
2242# EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
2243# the whole statement.
2244#print "APW <$lines[$realline_next - 1]>\n";
2245                if (defined $realline_next &&
2246                    exists $lines[$realline_next - 1] &&
2247                    !defined $suppress_export{$realline_next} &&
2248                    ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2249                     $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2250                        # Handle definitions which produce identifiers with
2251                        # a prefix:
2252                        #   XXX(foo);
2253                        #   EXPORT_SYMBOL(something_foo);
2254                        my $name = $1;
2255                        if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
2256                            $name =~ /^${Ident}_$2/) {
2257#print "FOO C name<$name>\n";
2258                                $suppress_export{$realline_next} = 1;
2259
2260                        } elsif ($stat !~ /(?:
2261                                \n.}\s*$|
2262                                ^.DEFINE_$Ident\(\Q$name\E\)|
2263                                ^.DECLARE_$Ident\(\Q$name\E\)|
2264                                ^.LIST_HEAD\(\Q$name\E\)|
2265                                ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
2266                                \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
2267                            )/x) {
2268#print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
2269                                $suppress_export{$realline_next} = 2;
2270                        } else {
2271                                $suppress_export{$realline_next} = 1;
2272                        }
2273                }
2274                if (!defined $suppress_export{$linenr} &&
2275                    $prevline =~ /^.\s*$/ &&
2276                    ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2277                     $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2278#print "FOO B <$lines[$linenr - 1]>\n";
2279                        $suppress_export{$linenr} = 2;
2280                }
2281                if (defined $suppress_export{$linenr} &&
2282                    $suppress_export{$linenr} == 2) {
2283                        WARN("EXPORT_SYMBOL",
2284                             "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
2285                }
2286
2287# check for global initialisers.
2288                if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
2289                        ERROR("GLOBAL_INITIALISERS",
2290                              "do not initialise globals to 0 or NULL\n" .
2291                                $herecurr);
2292                }
2293# check for static initialisers.
2294                if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
2295                        ERROR("INITIALISED_STATIC",
2296                              "do not initialise statics to 0 or NULL\n" .
2297                                $herecurr);
2298                }
2299
2300# check for static const char * arrays.
2301                if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
2302                        WARN("STATIC_CONST_CHAR_ARRAY",
2303                             "static const char * array should probably be static const char * const\n" .
2304                                $herecurr);
2305               }
2306
2307# check for static char foo[] = "bar" declarations.
2308                if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
2309                        WARN("STATIC_CONST_CHAR_ARRAY",
2310                             "static char array declaration should probably be static const char\n" .
2311                                $herecurr);
2312               }
2313
2314# check for declarations of struct pci_device_id
2315                if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
2316                        WARN("DEFINE_PCI_DEVICE_TABLE",
2317                             "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
2318                }
2319
2320# check for new typedefs, only function parameters and sparse annotations
2321# make sense.
2322                if ($line =~ /\btypedef\s/ &&
2323                    $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
2324                    $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
2325                    $line !~ /\b$typeTypedefs\b/ &&
2326                    $line !~ /\b__bitwise(?:__|)\b/) {
2327                        WARN("NEW_TYPEDEFS",
2328                             "do not add new typedefs\n" . $herecurr);
2329                }
2330
2331# * goes on variable not on type
2332                # (char*[ const])
2333                while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
2334                        #print "AA<$1>\n";
2335                        my ($from, $to) = ($2, $2);
2336
2337                        # Should start with a space.
2338                        $to =~ s/^(\S)/ $1/;
2339                        # Should not end with a space.
2340                        $to =~ s/\s+$//;
2341                        # '*'s should not have spaces between.
2342                        while ($to =~ s/\*\s+\*/\*\*/) {
2343                        }
2344
2345                        #print "from<$from> to<$to>\n";
2346                        if ($from ne $to) {
2347                                ERROR("POINTER_LOCATION",
2348                                      "\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr);
2349                        }
2350                }
2351                while ($line =~ m{(\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident))}g) {
2352                        #print "BB<$1>\n";
2353                        my ($from, $to, $ident) = ($2, $2, $3);
2354
2355                        # Should start with a space.
2356                        $to =~ s/^(\S)/ $1/;
2357                        # Should not end with a space.
2358                        $to =~ s/\s+$//;
2359                        # '*'s should not have spaces between.
2360                        while ($to =~ s/\*\s+\*/\*\*/) {
2361                        }
2362                        # Modifiers should have spaces.
2363                        $to =~ s/(\b$Modifier$)/$1 /;
2364
2365                        #print "from<$from> to<$to> ident<$ident>\n";
2366                        if ($from ne $to && $ident !~ /^$Modifier$/) {
2367                                ERROR("POINTER_LOCATION",
2368                                      "\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr);
2369                        }
2370                }
2371
2372# # no BUG() or BUG_ON()
2373#               if ($line =~ /\b(BUG|BUG_ON)\b/) {
2374#                       print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
2375#                       print "$herecurr";
2376#                       $clean = 0;
2377#               }
2378
2379                if ($line =~ /\bLINUX_VERSION_CODE\b/) {
2380                        WARN("LINUX_VERSION_CODE",
2381                             "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
2382                }
2383
2384# check for uses of printk_ratelimit
2385                if ($line =~ /\bprintk_ratelimit\s*\(/) {
2386                        WARN("PRINTK_RATELIMITED",
2387"Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
2388                }
2389
2390# printk should use KERN_* levels.  Note that follow on printk's on the
2391# same line do not need a level, so we use the current block context
2392# to try and find and validate the current printk.  In summary the current
2393# printk includes all preceding printk's which have no newline on the end.
2394# we assume the first bad printk is the one to report.
2395                if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
2396                        my $ok = 0;
2397                        for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
2398                                #print "CHECK<$lines[$ln - 1]\n";
2399                                # we have a preceding printk if it ends
2400                                # with "\n" ignore it, else it is to blame
2401                                if ($lines[$ln - 1] =~ m{\bprintk\(}) {
2402                                        if ($rawlines[$ln - 1] !~ m{\\n"}) {
2403                                                $ok = 1;
2404                                        }
2405                                        last;
2406                                }
2407                        }
2408                        if ($ok == 0) {
2409                                WARN("PRINTK_WITHOUT_KERN_LEVEL",
2410                                     "printk() should include KERN_ facility level\n" . $herecurr);
2411                        }
2412                }
2413
2414                if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
2415                        my $orig = $1;
2416                        my $level = lc($orig);
2417                        $level = "warn" if ($level eq "warning");
2418                        my $level2 = $level;
2419                        $level2 = "dbg" if ($level eq "debug");
2420                        WARN("PREFER_PR_LEVEL",
2421                             "Prefer netdev_$level2(netdev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
2422                }
2423
2424                if ($line =~ /\bpr_warning\s*\(/) {
2425                        WARN("PREFER_PR_LEVEL",
2426                             "Prefer pr_warn(... to pr_warning(...\n" . $herecurr);
2427                }
2428
2429# function brace can't be on same line, except for #defines of do while,
2430# or if closed on same line
2431                if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
2432                    !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
2433                        ERROR("OPEN_BRACE",
2434                              "open brace '{' following function declarations go on the next line\n" . $herecurr);
2435                }
2436
2437# open braces for enum, union and struct go on the same line.
2438                if ($line =~ /^.\s*{/ &&
2439                    $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
2440                        ERROR("OPEN_BRACE",
2441                              "open brace '{' following $1 go on the same line\n" . $hereprev);
2442                }
2443
2444# missing space after union, struct or enum definition
2445                if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) {
2446                    WARN("SPACING",
2447                         "missing space after $1 definition\n" . $herecurr);
2448                }
2449
2450# check for spacing round square brackets; allowed:
2451#  1. with a type on the left -- int [] a;
2452#  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
2453#  3. inside a curly brace -- = { [0...10] = 5 }
2454                while ($line =~ /(.*?\s)\[/g) {
2455                        my ($where, $prefix) = ($-[1], $1);
2456                        if ($prefix !~ /$Type\s+$/ &&
2457                            ($where != 0 || $prefix !~ /^.\s+$/) &&
2458                            $prefix !~ /[{,]\s+$/) {
2459                                ERROR("BRACKET_SPACE",
2460                                      "space prohibited before open square bracket '['\n" . $herecurr);
2461                        }
2462                }
2463
2464# check for spaces between functions and their parentheses.
2465                while ($line =~ /($Ident)\s+\(/g) {
2466                        my $name = $1;
2467                        my $ctx_before = substr($line, 0, $-[1]);
2468                        my $ctx = "$ctx_before$name";
2469
2470                        # Ignore those directives where spaces _are_ permitted.
2471                        if ($name =~ /^(?:
2472                                if|for|while|switch|return|case|
2473                                volatile|__volatile__|
2474                                __attribute__|format|__extension__|
2475                                asm|__asm__)$/x)
2476                        {
2477
2478                        # cpp #define statements have non-optional spaces, ie
2479                        # if there is a space between the name and the open
2480                        # parenthesis it is simply not a parameter group.
2481                        } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
2482
2483                        # cpp #elif statement condition may start with a (
2484                        } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
2485
2486                        # If this whole things ends with a type its most
2487                        # likely a typedef for a function.
2488                        } elsif ($ctx =~ /$Type$/) {
2489
2490                        } else {
2491                                WARN("SPACING",
2492                                     "space prohibited between function name and open parenthesis '('\n" . $herecurr);
2493                        }
2494                }
2495
2496# check for whitespace before a non-naked semicolon
2497                if ($line =~ /^\+.*\S\s+;/) {
2498                        CHK("SPACING",
2499                            "space prohibited before semicolon\n" . $herecurr);
2500                }
2501
2502# Check operator spacing.
2503                if (!($line=~/\#\s*include/)) {
2504                        my $ops = qr{
2505                                <<=|>>=|<=|>=|==|!=|
2506                                \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
2507                                =>|->|<<|>>|<|>|=|!|~|
2508                                &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
2509                                \?|:
2510                        }x;
2511                        my @elements = split(/($ops|;)/, $opline);
2512                        my $off = 0;
2513
2514                        my $blank = copy_spacing($opline);
2515
2516                        for (my $n = 0; $n < $#elements; $n += 2) {
2517                                $off += length($elements[$n]);
2518
2519                                # Pick up the preceding and succeeding characters.
2520                                my $ca = substr($opline, 0, $off);
2521                                my $cc = '';
2522                                if (length($opline) >= ($off + length($elements[$n + 1]))) {
2523                                        $cc = substr($opline, $off + length($elements[$n + 1]));
2524                                }
2525                                my $cb = "$ca$;$cc";
2526
2527                                my $a = '';
2528                                $a = 'V' if ($elements[$n] ne '');
2529                                $a = 'W' if ($elements[$n] =~ /\s$/);
2530                                $a = 'C' if ($elements[$n] =~ /$;$/);
2531                                $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
2532                                $a = 'O' if ($elements[$n] eq '');
2533                                $a = 'E' if ($ca =~ /^\s*$/);
2534
2535                                my $op = $elements[$n + 1];
2536
2537                                my $c = '';
2538                                if (defined $elements[$n + 2]) {
2539                                        $c = 'V' if ($elements[$n + 2] ne '');
2540                                        $c = 'W' if ($elements[$n + 2] =~ /^\s/);
2541                                        $c = 'C' if ($elements[$n + 2] =~ /^$;/);
2542                                        $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
2543                                        $c = 'O' if ($elements[$n + 2] eq '');
2544                                        $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
2545                                } else {
2546                                        $c = 'E';
2547                                }
2548
2549                                my $ctx = "${a}x${c}";
2550
2551                                my $at = "(ctx:$ctx)";
2552
2553                                my $ptr = substr($blank, 0, $off) . "^";
2554                                my $hereptr = "$hereline$ptr\n";
2555
2556                                # Pull out the value of this operator.
2557                                my $op_type = substr($curr_values, $off + 1, 1);
2558
2559                                # Get the full operator variant.
2560                                my $opv = $op . substr($curr_vars, $off, 1);
2561
2562                                # Ignore operators passed as parameters.
2563                                if ($op_type ne 'V' &&
2564                                    $ca =~ /\s$/ && $cc =~ /^\s*,/) {
2565
2566#                               # Ignore comments
2567#                               } elsif ($op =~ /^$;+$/) {
2568
2569                                # ; should have either the end of line or a space or \ after it
2570                                } elsif ($op eq ';') {
2571                                        if ($ctx !~ /.x[WEBC]/ &&
2572                                            $cc !~ /^\\/ && $cc !~ /^;/) {
2573                                                ERROR("SPACING",
2574                                                      "space required after that '$op' $at\n" . $hereptr);
2575                                        }
2576
2577                                # // is a comment
2578                                } elsif ($op eq '//') {
2579
2580                                # No spaces for:
2581                                #   ->
2582                                #   :   when part of a bitfield
2583                                } elsif ($op eq '->' || $opv eq ':B') {
2584                                        if ($ctx =~ /Wx.|.xW/) {
2585                                                ERROR("SPACING",
2586                                                      "spaces prohibited around that '$op' $at\n" . $hereptr);
2587                                        }
2588
2589                                # , must have a space on the right.
2590                                } elsif ($op eq ',') {
2591                                        if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
2592                                                ERROR("SPACING",
2593                                                      "space required after that '$op' $at\n" . $hereptr);
2594                                        }
2595
2596                                # '*' as part of a type definition -- reported already.
2597                                } elsif ($opv eq '*_') {
2598                                        #warn "'*' is part of type\n";
2599
2600                                # unary operators should have a space before and
2601                                # none after.  May be left adjacent to another
2602                                # unary operator, or a cast
2603                                } elsif ($op eq '!' || $op eq '~' ||
2604                                         $opv eq '*U' || $opv eq '-U' ||
2605                                         $opv eq '&U' || $opv eq '&&U') {
2606                                        if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
2607                                                ERROR("SPACING",
2608                                                      "space required before that '$op' $at\n" . $hereptr);
2609                                        }
2610                                        if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
2611                                                # A unary '*' may be const
2612
2613                                        } elsif ($ctx =~ /.xW/) {
2614                                                ERROR("SPACING",
2615                                                      "space prohibited after that '$op' $at\n" . $hereptr);
2616                                        }
2617
2618                                # unary ++ and unary -- are allowed no space on one side.
2619                                } elsif ($op eq '++' or $op eq '--') {
2620                                        if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
2621                                                ERROR("SPACING",
2622                                                      "space required one side of that '$op' $at\n" . $hereptr);
2623                                        }
2624                                        if ($ctx =~ /Wx[BE]/ ||
2625                                            ($ctx =~ /Wx./ && $cc =~ /^;/)) {
2626                                                ERROR("SPACING",
2627                                                      "space prohibited before that '$op' $at\n" . $hereptr);
2628                                        }
2629                                        if ($ctx =~ /ExW/) {
2630                                                ERROR("SPACING",
2631                                                      "space prohibited after that '$op' $at\n" . $hereptr);
2632                                        }
2633
2634
2635                                # << and >> may either have or not have spaces both sides
2636                                } elsif ($op eq '<<' or $op eq '>>' or
2637                                         $op eq '&' or $op eq '^' or $op eq '|' or
2638                                         $op eq '+' or $op eq '-' or
2639                                         $op eq '*' or $op eq '/' or
2640                                         $op eq '%')
2641                                {
2642                                        if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
2643                                                ERROR("SPACING",
2644                                                      "need consistent spacing around '$op' $at\n" .
2645                                                        $hereptr);
2646                                        }
2647
2648                                # A colon needs no spaces before when it is
2649                                # terminating a case value or a label.
2650                                } elsif ($opv eq ':C' || $opv eq ':L') {
2651                                        if ($ctx =~ /Wx./) {
2652                                                ERROR("SPACING",
2653                                                      "space prohibited before that '$op' $at\n" . $hereptr);
2654                                        }
2655
2656                                # All the others need spaces both sides.
2657                                } elsif ($ctx !~ /[EWC]x[CWE]/) {
2658                                        my $ok = 0;
2659
2660                                        # Ignore email addresses <foo@bar>
2661                                        if (($op eq '<' &&
2662                                             $cc =~ /^\S+\@\S+>/) ||
2663                                            ($op eq '>' &&
2664                                             $ca =~ /<\S+\@\S+$/))
2665                                        {
2666                                                $ok = 1;
2667                                        }
2668
2669                                        # Ignore ?:
2670                                        if (($opv eq ':O' && $ca =~ /\?$/) ||
2671                                            ($op eq '?' && $cc =~ /^:/)) {
2672                                                $ok = 1;
2673                                        }
2674
2675                                        if ($ok == 0) {
2676                                                ERROR("SPACING",
2677                                                      "spaces required around that '$op' $at\n" . $hereptr);
2678                                        }
2679                                }
2680                                $off += length($elements[$n + 1]);
2681                        }
2682                }
2683
2684# check for multiple assignments
2685                if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
2686                        CHK("MULTIPLE_ASSIGNMENTS",
2687                            "multiple assignments should be avoided\n" . $herecurr);
2688                }
2689
2690## # check for multiple declarations, allowing for a function declaration
2691## # continuation.
2692##              if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
2693##                  $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
2694##
2695##                      # Remove any bracketed sections to ensure we do not
2696##                      # falsly report the parameters of functions.
2697##                      my $ln = $line;
2698##                      while ($ln =~ s/\([^\(\)]*\)//g) {
2699##                      }
2700##                      if ($ln =~ /,/) {
2701##                              WARN("MULTIPLE_DECLARATION",
2702##                                   "declaring multiple variables together should be avoided\n" . $herecurr);
2703##                      }
2704##              }
2705
2706#need space before brace following if, while, etc
2707                if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
2708                    $line =~ /do{/) {
2709                        ERROR("SPACING",
2710                              "space required before the open brace '{'\n" . $herecurr);
2711                }
2712
2713# closing brace should have a space following it when it has anything
2714# on the line
2715                if ($line =~ /}(?!(?:,|;|\)))\S/) {
2716                        ERROR("SPACING",
2717                              "space required after that close brace '}'\n" . $herecurr);
2718                }
2719
2720# check spacing on square brackets
2721                if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
2722                        ERROR("SPACING",
2723                              "space prohibited after that open square bracket '['\n" . $herecurr);
2724                }
2725                if ($line =~ /\s\]/) {
2726                        ERROR("SPACING",
2727                              "space prohibited before that close square bracket ']'\n" . $herecurr);
2728                }
2729
2730# check spacing on parentheses
2731                if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
2732                    $line !~ /for\s*\(\s+;/) {
2733                        ERROR("SPACING",
2734                              "space prohibited after that open parenthesis '('\n" . $herecurr);
2735                }
2736                if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
2737                    $line !~ /for\s*\(.*;\s+\)/ &&
2738                    $line !~ /:\s+\)/) {
2739                        ERROR("SPACING",
2740                              "space prohibited before that close parenthesis ')'\n" . $herecurr);
2741                }
2742
2743#goto labels aren't indented, allow a single space however
2744                if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
2745                   !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
2746                        WARN("INDENTED_LABEL",
2747                             "labels should not be indented\n" . $herecurr);
2748                }
2749
2750# Return is not a function.
2751                if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
2752                        my $spacing = $1;
2753                        my $value = $2;
2754
2755                        # Flatten any parentheses
2756                        $value =~ s/\(/ \(/g;
2757                        $value =~ s/\)/\) /g;
2758                        while ($value =~ s/\[[^\[\]]*\]/1/ ||
2759                               $value !~ /(?:$Ident|-?$Constant)\s*
2760                                             $Compare\s*
2761                                             (?:$Ident|-?$Constant)/x &&
2762                               $value =~ s/\([^\(\)]*\)/1/) {
2763                        }
2764#print "value<$value>\n";
2765                        if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
2766                                ERROR("RETURN_PARENTHESES",
2767                                      "return is not a function, parentheses are not required\n" . $herecurr);
2768
2769                        } elsif ($spacing !~ /\s+/) {
2770                                ERROR("SPACING",
2771                                      "space required before the open parenthesis '('\n" . $herecurr);
2772                        }
2773                }
2774# Return of what appears to be an errno should normally be -'ve
2775                if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
2776                        my $name = $1;
2777                        if ($name ne 'EOF' && $name ne 'ERROR') {
2778                                WARN("USE_NEGATIVE_ERRNO",
2779                                     "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
2780                        }
2781                }
2782
2783# Need a space before open parenthesis after if, while etc
2784                if ($line=~/\b(if|while|for|switch)\(/) {
2785                        ERROR("SPACING", "space required before the open parenthesis '('\n" . $herecurr);
2786                }
2787
2788# Check for illegal assignment in if conditional -- and check for trailing
2789# statements after the conditional.
2790                if ($line =~ /do\s*(?!{)/) {
2791                        ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2792                                ctx_statement_block($linenr, $realcnt, 0)
2793                                        if (!defined $stat);
2794                        my ($stat_next) = ctx_statement_block($line_nr_next,
2795                                                $remain_next, $off_next);
2796                        $stat_next =~ s/\n./\n /g;
2797                        ##print "stat<$stat> stat_next<$stat_next>\n";
2798
2799                        if ($stat_next =~ /^\s*while\b/) {
2800                                # If the statement carries leading newlines,
2801                                # then count those as offsets.
2802                                my ($whitespace) =
2803                                        ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
2804                                my $offset =
2805                                        statement_rawlines($whitespace) - 1;
2806
2807                                $suppress_whiletrailers{$line_nr_next +
2808                                                                $offset} = 1;
2809                        }
2810                }
2811                if (!defined $suppress_whiletrailers{$linenr} &&
2812                    $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
2813                        my ($s, $c) = ($stat, $cond);
2814
2815                        if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
2816                                ERROR("ASSIGN_IN_IF",
2817                                      "do not use assignment in if condition\n" . $herecurr);
2818                        }
2819
2820                        # Find out what is on the end of the line after the
2821                        # conditional.
2822                        substr($s, 0, length($c), '');
2823                        $s =~ s/\n.*//g;
2824                        $s =~ s/$;//g;  # Remove any comments
2825                        if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
2826                            $c !~ /}\s*while\s*/)
2827                        {
2828                                # Find out how long the conditional actually is.
2829                                my @newlines = ($c =~ /\n/gs);
2830                                my $cond_lines = 1 + $#newlines;
2831                                my $stat_real = '';
2832
2833                                $stat_real = raw_line($linenr, $cond_lines)
2834                                                        . "\n" if ($cond_lines);
2835                                if (defined($stat_real) && $cond_lines > 1) {
2836                                        $stat_real = "[...]\n$stat_real";
2837                                }
2838
2839                                ERROR("TRAILING_STATEMENTS",
2840                                      "trailing statements should be on next line\n" . $herecurr . $stat_real);
2841                        }
2842                }
2843
2844# Check for bitwise tests written as boolean
2845                if ($line =~ /
2846                        (?:
2847                                (?:\[|\(|\&\&|\|\|)
2848                                \s*0[xX][0-9]+\s*
2849                                (?:\&\&|\|\|)
2850                        |
2851                                (?:\&\&|\|\|)
2852                                \s*0[xX][0-9]+\s*
2853                                (?:\&\&|\|\||\)|\])
2854                        )/x)
2855                {
2856                        WARN("HEXADECIMAL_BOOLEAN_TEST",
2857                             "boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
2858                }
2859
2860# if and else should not have general statements after it
2861                if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
2862                        my $s = $1;
2863                        $s =~ s/$;//g;  # Remove any comments
2864                        if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
2865                                ERROR("TRAILING_STATEMENTS",
2866                                      "trailing statements should be on next line\n" . $herecurr);
2867                        }
2868                }
2869# if should not continue a brace
2870                if ($line =~ /}\s*if\b/) {
2871                        ERROR("TRAILING_STATEMENTS",
2872                              "trailing statements should be on next line\n" .
2873                                $herecurr);
2874                }
2875# case and default should not have general statements after them
2876                if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
2877                    $line !~ /\G(?:
2878                        (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
2879                        \s*return\s+
2880                    )/xg)
2881                {
2882                        ERROR("TRAILING_STATEMENTS",
2883                              "trailing statements should be on next line\n" . $herecurr);
2884                }
2885
2886                # Check for }<nl>else {, these must be at the same
2887                # indent level to be relevant to each other.
2888                if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
2889                                                $previndent == $indent) {
2890                        ERROR("ELSE_AFTER_BRACE",
2891                              "else should follow close brace '}'\n" . $hereprev);
2892                }
2893
2894                if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
2895                                                $previndent == $indent) {
2896                        my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
2897
2898                        # Find out what is on the end of the line after the
2899                        # conditional.
2900                        substr($s, 0, length($c), '');
2901                        $s =~ s/\n.*//g;
2902
2903                        if ($s =~ /^\s*;/) {
2904                                ERROR("WHILE_AFTER_BRACE",
2905                                      "while should follow close brace '}'\n" . $hereprev);
2906                        }
2907                }
2908
2909#studly caps, commented out until figure out how to distinguish between use of existing and adding new
2910#               if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
2911#                   print "No studly caps, use _\n";
2912#                   print "$herecurr";
2913#                   $clean = 0;
2914#               }
2915
2916#no spaces allowed after \ in define
2917                if ($line=~/\#\s*define.*\\\s$/) {
2918                        WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
2919                             "Whitepspace after \\ makes next lines useless\n" . $herecurr);
2920                }
2921
2922#warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
2923                if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
2924                        my $file = "$1.h";
2925                        my $checkfile = "include/linux/$file";
2926                        if (-f "$root/$checkfile" &&
2927                            $realfile ne $checkfile &&
2928                            $1 !~ /$allowed_asm_includes/)
2929                        {
2930                                if ($realfile =~ m{^arch/}) {
2931                                        CHK("ARCH_INCLUDE_LINUX",
2932                                            "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2933                                } else {
2934                                        WARN("INCLUDE_LINUX",
2935                                             "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2936                                }
2937                        }
2938                }
2939
2940# multi-statement macros should be enclosed in a do while loop, grab the
2941# first statement and ensure its the whole macro if its not enclosed
2942# in a known good container
2943                if ($realfile !~ m@/vmlinux.lds.h$@ &&
2944                    $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
2945                        my $ln = $linenr;
2946                        my $cnt = $realcnt;
2947                        my ($off, $dstat, $dcond, $rest);
2948                        my $ctx = '';
2949                        ($dstat, $dcond, $ln, $cnt, $off) =
2950                                ctx_statement_block($linenr, $realcnt, 0);
2951                        $ctx = $dstat;
2952                        #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
2953                        #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
2954
2955                        $dstat =~ s/^.\s*\#\s*define\s+$Ident(?:\([^\)]*\))?\s*//;
2956                        $dstat =~ s/$;//g;
2957                        $dstat =~ s/\\\n.//g;
2958                        $dstat =~ s/^\s*//s;
2959                        $dstat =~ s/\s*$//s;
2960
2961                        # Flatten any parentheses and braces
2962                        while ($dstat =~ s/\([^\(\)]*\)/1/ ||
2963                               $dstat =~ s/\{[^\{\}]*\}/1/ ||
2964                               $dstat =~ s/\[[^\[\]]*\]/1/)
2965                        {
2966                        }
2967
2968                        # Flatten any obvious string concatentation.
2969                        while ($dstat =~ s/("X*")\s*$Ident/$1/ ||
2970                               $dstat =~ s/$Ident\s*("X*")/$1/)
2971                        {
2972                        }
2973
2974                        my $exceptions = qr{
2975                                $Declare|
2976                                module_param_named|
2977                                MODULE_PARM_DESC|
2978                                DECLARE_PER_CPU|
2979                                DEFINE_PER_CPU|
2980                                __typeof__\(|
2981                                union|
2982                                struct|
2983                                \.$Ident\s*=\s*|
2984                                ^\"|\"$
2985                        }x;
2986                        #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
2987                        if ($dstat ne '' &&
2988                            $dstat !~ /^(?:$Ident|-?$Constant),$/ &&                    # 10, // foo(),
2989                            $dstat !~ /^(?:$Ident|-?$Constant);$/ &&                    # foo();
2990                            $dstat !~ /^[!~-]?(?:$Ident|$Constant)$/ &&         # 10 // foo() // !foo // ~foo // -foo
2991                            $dstat !~ /^'X'$/ &&                                        # character constants
2992                            $dstat !~ /$exceptions/ &&
2993                            $dstat !~ /^\.$Ident\s*=/ &&                                # .foo =
2994                            $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ &&       # do {...} while (...); // do {...} while (...)
2995                            $dstat !~ /^for\s*$Constant$/ &&                            # for (...)
2996                            $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ &&   # for (...) bar()
2997                            $dstat !~ /^do\s*{/ &&                                      # do {...
2998                            $dstat !~ /^\({/)                                           # ({...
2999                        {
3000                                $ctx =~ s/\n*$//;
3001                                my $herectx = $here . "\n";
3002                                my $cnt = statement_rawlines($ctx);
3003
3004                                for (my $n = 0; $n < $cnt; $n++) {
3005                                        $herectx .= raw_line($linenr, $n) . "\n";
3006                                }
3007
3008                                if ($dstat =~ /;/) {
3009                                        ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
3010                                              "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
3011                                } else {
3012                                        ERROR("COMPLEX_MACRO",
3013                                              "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
3014                                }
3015                        }
3016                }
3017
3018# do {} while (0) macro tests:
3019# single-statement macros do not need to be enclosed in do while (0) loop,
3020# macro should not end with a semicolon
3021                if ($^V && $^V ge 5.10.0 &&
3022                    $realfile !~ m@/vmlinux.lds.h$@ &&
3023                    $line =~ /^.\s*\#\s*define\s+$Ident(\()?/) {
3024                        my $ln = $linenr;
3025                        my $cnt = $realcnt;
3026                        my ($off, $dstat, $dcond, $rest);
3027                        my $ctx = '';
3028                        ($dstat, $dcond, $ln, $cnt, $off) =
3029                                ctx_statement_block($linenr, $realcnt, 0);
3030                        $ctx = $dstat;
3031
3032                        $dstat =~ s/\\\n.//g;
3033
3034                        if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
3035                                my $stmts = $2;
3036                                my $semis = $3;
3037
3038                                $ctx =~ s/\n*$//;
3039                                my $cnt = statement_rawlines($ctx);
3040                                my $herectx = $here . "\n";
3041
3042                                for (my $n = 0; $n < $cnt; $n++) {
3043                                        $herectx .= raw_line($linenr, $n) . "\n";
3044                                }
3045
3046                                if (($stmts =~ tr/;/;/) == 1 &&
3047                                    $stmts !~ /^\s*(if|while|for|switch)\b/) {
3048                                        WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
3049                                             "Single statement macros should not use a do {} while (0) loop\n" . "$herectx");
3050                                }
3051                                if (defined $semis && $semis ne "") {
3052                                        WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON",
3053                                             "do {} while (0) macros should not be semicolon terminated\n" . "$herectx");
3054                                }
3055                        }
3056                }
3057
3058# make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
3059# all assignments may have only one of the following with an assignment:
3060#       .
3061#       ALIGN(...)
3062#       VMLINUX_SYMBOL(...)
3063                if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
3064                        WARN("MISSING_VMLINUX_SYMBOL",
3065                             "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
3066                }
3067
3068# check for redundant bracing round if etc
3069                if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
3070                        my ($level, $endln, @chunks) =
3071                                ctx_statement_full($linenr, $realcnt, 1);
3072                        #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
3073                        #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
3074                        if ($#chunks > 0 && $level == 0) {
3075                                my @allowed = ();
3076                                my $allow = 0;
3077                                my $seen = 0;
3078                                my $herectx = $here . "\n";
3079                                my $ln = $linenr - 1;
3080                                for my $chunk (@chunks) {
3081                                        my ($cond, $block) = @{$chunk};
3082
3083                                        # If the condition carries leading newlines, then count those as offsets.
3084                                        my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
3085                                        my $offset = statement_rawlines($whitespace) - 1;
3086
3087                                        $allowed[$allow] = 0;
3088                                        #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
3089
3090                                        # We have looked at and allowed this specific line.
3091                                        $suppress_ifbraces{$ln + $offset} = 1;
3092
3093                                        $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
3094                                        $ln += statement_rawlines($block) - 1;
3095
3096                                        substr($block, 0, length($cond), '');
3097
3098                                        $seen++ if ($block =~ /^\s*{/);
3099
3100                                        #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
3101                                        if (statement_lines($cond) > 1) {
3102                                                #print "APW: ALLOWED: cond<$cond>\n";
3103                                                $allowed[$allow] = 1;
3104                                        }
3105                                        if ($block =~/\b(?:if|for|while)\b/) {
3106                                                #print "APW: ALLOWED: block<$block>\n";
3107                                                $allowed[$allow] = 1;
3108                                        }
3109                                        if (statement_block_size($block) > 1) {
3110                                                #print "APW: ALLOWED: lines block<$block>\n";
3111                                                $allowed[$allow] = 1;
3112                                        }
3113                                        $allow++;
3114                                }
3115                                if ($seen) {
3116                                        my $sum_allowed = 0;
3117                                        foreach (@allowed) {
3118                                                $sum_allowed += $_;
3119                                        }
3120                                        if ($sum_allowed == 0) {
3121                                                WARN("BRACES",
3122                                                     "braces {} are not necessary for any arm of this statement\n" . $herectx);
3123                                        } elsif ($sum_allowed != $allow &&
3124                                                 $seen != $allow) {
3125                                                CHK("BRACES",
3126                                                    "braces {} should be used on all arms of this statement\n" . $herectx);
3127                                        }
3128                                }
3129                        }
3130                }
3131                if (!defined $suppress_ifbraces{$linenr - 1} &&
3132                                        $line =~ /\b(if|while|for|else)\b/) {
3133                        my $allowed = 0;
3134
3135                        # Check the pre-context.
3136                        if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
3137                                #print "APW: ALLOWED: pre<$1>\n";
3138                                $allowed = 1;
3139                        }
3140
3141                        my ($level, $endln, @chunks) =
3142                                ctx_statement_full($linenr, $realcnt, $-[0]);
3143
3144                        # Check the condition.
3145                        my ($cond, $block) = @{$chunks[0]};
3146                        #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
3147                        if (defined $cond) {
3148                                substr($block, 0, length($cond), '');
3149                        }
3150                        if (statement_lines($cond) > 1) {
3151                                #print "APW: ALLOWED: cond<$cond>\n";
3152                                $allowed = 1;
3153                        }
3154                        if ($block =~/\b(?:if|for|while)\b/) {
3155                                #print "APW: ALLOWED: block<$block>\n";
3156                                $allowed = 1;
3157                        }
3158                        if (statement_block_size($block) > 1) {
3159                                #print "APW: ALLOWED: lines block<$block>\n";
3160                                $allowed = 1;
3161                        }
3162                        # Check the post-context.
3163                        if (defined $chunks[1]) {
3164                                my ($cond, $block) = @{$chunks[1]};
3165                                if (defined $cond) {
3166                                        substr($block, 0, length($cond), '');
3167                                }
3168                                if ($block =~ /^\s*\{/) {
3169                                        #print "APW: ALLOWED: chunk-1 block<$block>\n";
3170                                        $allowed = 1;
3171                                }
3172                        }
3173                        if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
3174                                my $herectx = $here . "\n";
3175                                my $cnt = statement_rawlines($block);
3176
3177                                for (my $n = 0; $n < $cnt; $n++) {
3178                                        $herectx .= raw_line($linenr, $n) . "\n";
3179                                }
3180
3181                                WARN("BRACES",
3182                                     "braces {} are not necessary for single statement blocks\n" . $herectx);
3183                        }
3184                }
3185
3186# don't include deprecated include files (uses RAW line)
3187                for my $inc (@dep_includes) {
3188                        if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
3189                                ERROR("DEPRECATED_INCLUDE",
3190                                      "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
3191                        }
3192                }
3193
3194# don't use deprecated functions
3195                for my $func (@dep_functions) {
3196                        if ($line =~ /\b$func\b/) {
3197                                ERROR("DEPRECATED_FUNCTION",
3198                                      "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
3199                        }
3200                }
3201
3202# no volatiles please
3203                my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
3204                if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
3205                        WARN("VOLATILE",
3206                             "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
3207                }
3208
3209# warn about #if 0
3210                if ($line =~ /^.\s*\#\s*if\s+0\b/) {
3211                        CHK("REDUNDANT_CODE",
3212                            "if this code is redundant consider removing it\n" .
3213                                $herecurr);
3214                }
3215
3216# check for needless kfree() checks
3217                if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3218                        my $expr = $1;
3219                        if ($line =~ /\bkfree\(\Q$expr\E\);/) {
3220                                WARN("NEEDLESS_KFREE",
3221                                     "kfree(NULL) is safe this check is probably not required\n" . $hereprev);
3222                        }
3223                }
3224# check for needless usb_free_urb() checks
3225                if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3226                        my $expr = $1;
3227                        if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
3228                                WARN("NEEDLESS_USB_FREE_URB",
3229                                     "usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
3230                        }
3231                }
3232
3233# prefer usleep_range over udelay
3234                if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
3235                        # ignore udelay's < 10, however
3236                        if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
3237                                CHK("USLEEP_RANGE",
3238                                    "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
3239                        }
3240                }
3241
3242# warn about unexpectedly long msleep's
3243                if ($line =~ /\bmsleep\s*\((\d+)\);/) {
3244                        if ($1 < 20) {
3245                                WARN("MSLEEP",
3246                                     "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
3247                        }
3248                }
3249
3250# warn about #ifdefs in C files
3251#               if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
3252#                       print "#ifdef in C files should be avoided\n";
3253#                       print "$herecurr";
3254#                       $clean = 0;
3255#               }
3256
3257# warn about spacing in #ifdefs
3258                if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
3259                        ERROR("SPACING",
3260                              "exactly one space required after that #$1\n" . $herecurr);
3261                }
3262
3263# check for spinlock_t definitions without a comment.
3264                if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
3265                    $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
3266                        my $which = $1;
3267                        if (!ctx_has_comment($first_line, $linenr)) {
3268                                CHK("UNCOMMENTED_DEFINITION",
3269                                    "$1 definition without comment\n" . $herecurr);
3270                        }
3271                }
3272# check for memory barriers without a comment.
3273                if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
3274                        if (!ctx_has_comment($first_line, $linenr)) {
3275                                CHK("MEMORY_BARRIER",
3276                                    "memory barrier without comment\n" . $herecurr);
3277                        }
3278                }
3279# check of hardware specific defines
3280                if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
3281                        CHK("ARCH_DEFINES",
3282                            "architecture specific defines should be avoided\n" .  $herecurr);
3283                }
3284
3285# Check that the storage class is at the beginning of a declaration
3286                if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
3287                        WARN("STORAGE_CLASS",
3288                             "storage class should be at the beginning of the declaration\n" . $herecurr)
3289                }
3290
3291# check the location of the inline attribute, that it is between
3292# storage class and type.
3293                if ($line =~ /\b$Type\s+$Inline\b/ ||
3294                    $line =~ /\b$Inline\s+$Storage\b/) {
3295                        ERROR("INLINE_LOCATION",
3296                              "inline keyword should sit between storage class and type\n" . $herecurr);
3297                }
3298
3299# Check for __inline__ and __inline, prefer inline
3300                if ($line =~ /\b(__inline__|__inline)\b/) {
3301                        WARN("INLINE",
3302                             "plain inline is preferred over $1\n" . $herecurr);
3303                }
3304
3305# Check for __attribute__ packed, prefer __packed
3306                if ($line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
3307                        WARN("PREFER_PACKED",
3308                             "__packed is preferred over __attribute__((packed))\n" . $herecurr);
3309                }
3310
3311# Check for __attribute__ aligned, prefer __aligned
3312                if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
3313                        WARN("PREFER_ALIGNED",
3314                             "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
3315                }
3316
3317# Check for __attribute__ format(printf, prefer __printf
3318                if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
3319                        WARN("PREFER_PRINTF",
3320                             "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr);
3321                }
3322
3323# Check for __attribute__ format(scanf, prefer __scanf
3324                if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\b/) {
3325                        WARN("PREFER_SCANF",
3326                             "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr);
3327                }
3328
3329# check for sizeof(&)
3330                if ($line =~ /\bsizeof\s*\(\s*\&/) {
3331                        WARN("SIZEOF_ADDRESS",
3332                             "sizeof(& should be avoided\n" . $herecurr);
3333                }
3334
3335# check for sizeof without parenthesis
3336                if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) {
3337                        WARN("SIZEOF_PARENTHESIS",
3338                             "sizeof $1 should be sizeof($1)\n" . $herecurr);
3339                }
3340
3341# check for line continuations in quoted strings with odd counts of "
3342                if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
3343                        WARN("LINE_CONTINUATIONS",
3344                             "Avoid line continuations in quoted strings\n" . $herecurr);
3345                }
3346
3347# Check for misused memsets
3348                if ($^V && $^V ge 5.10.0 &&
3349                    defined $stat &&
3350                    $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) {
3351
3352                        my $ms_addr = $2;
3353                        my $ms_val = $7;
3354                        my $ms_size = $12;
3355
3356                        if ($ms_size =~ /^(0x|)0$/i) {
3357                                ERROR("MEMSET",
3358                                      "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
3359                        } elsif ($ms_size =~ /^(0x|)1$/i) {
3360                                WARN("MEMSET",
3361                                     "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
3362                        }
3363                }
3364
3365# typecasts on min/max could be min_t/max_t
3366                if ($^V && $^V ge 5.10.0 &&
3367                    defined $stat &&
3368                    $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
3369                        if (defined $2 || defined $7) {
3370                                my $call = $1;
3371                                my $cast1 = deparenthesize($2);
3372                                my $arg1 = $3;
3373                                my $cast2 = deparenthesize($7);
3374                                my $arg2 = $8;
3375                                my $cast;
3376
3377                                if ($cast1 ne "" && $cast2 ne "" && $cast1 ne $cast2) {
3378                                        $cast = "$cast1 or $cast2";
3379                                } elsif ($cast1 ne "") {
3380                                        $cast = $cast1;
3381                                } else {
3382                                        $cast = $cast2;
3383                                }
3384                                WARN("MINMAX",
3385                                     "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
3386                        }
3387                }
3388
3389# check usleep_range arguments
3390                if ($^V && $^V ge 5.10.0 &&
3391                    defined $stat &&
3392                    $stat =~ /^\+(?:.*?)\busleep_range\s*\(\s*($FuncArg)\s*,\s*($FuncArg)\s*\)/) {
3393                        my $min = $1;
3394                        my $max = $7;
3395                        if ($min eq $max) {
3396                                WARN("USLEEP_RANGE",
3397                                     "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
3398                        } elsif ($min =~ /^\d+$/ && $max =~ /^\d+$/ &&
3399                                 $min > $max) {
3400                                WARN("USLEEP_RANGE",
3401                                     "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
3402                        }
3403                }
3404
3405# check for new externs in .c files.
3406                if ($realfile =~ /\.c$/ && defined $stat &&
3407                    $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
3408                {
3409                        my $function_name = $1;
3410                        my $paren_space = $2;
3411
3412                        my $s = $stat;
3413                        if (defined $cond) {
3414                                substr($s, 0, length($cond), '');
3415                        }
3416                        if ($s =~ /^\s*;/ &&
3417                            $function_name ne 'uninitialized_var')
3418                        {
3419                                WARN("AVOID_EXTERNS",
3420                                     "externs should be avoided in .c files\n" .  $herecurr);
3421                        }
3422
3423                        if ($paren_space =~ /\n/) {
3424                                WARN("FUNCTION_ARGUMENTS",
3425                                     "arguments for function declarations should follow identifier\n" . $herecurr);
3426                        }
3427
3428                } elsif ($realfile =~ /\.c$/ && defined $stat &&
3429                    $stat =~ /^.\s*extern\s+/)
3430                {
3431                        WARN("AVOID_EXTERNS",
3432                             "externs should be avoided in .c files\n" .  $herecurr);
3433                }
3434
3435# checks for new __setup's
3436                if ($rawline =~ /\b__setup\("([^"]*)"/) {
3437                        my $name = $1;
3438
3439                        if (!grep(/$name/, @setup_docs)) {
3440                                CHK("UNDOCUMENTED_SETUP",
3441                                    "__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
3442                        }
3443                }
3444
3445# check for pointless casting of kmalloc return
3446                if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
3447                        WARN("UNNECESSARY_CASTS",
3448                             "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
3449                }
3450
3451# check for multiple semicolons
3452                if ($line =~ /;\s*;\s*$/) {
3453                    WARN("ONE_SEMICOLON",
3454                         "Statements terminations use 1 semicolon\n" . $herecurr);
3455                }
3456
3457# check for gcc specific __FUNCTION__
3458                if ($line =~ /__FUNCTION__/) {
3459                        WARN("USE_FUNC",
3460                             "__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
3461                }
3462
3463# check for use of yield()
3464                if ($line =~ /\byield\s*\(\s*\)/) {
3465                        WARN("YIELD",
3466                             "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n"  . $herecurr);
3467                }
3468
3469# check for semaphores initialized locked
3470                if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
3471                        WARN("CONSIDER_COMPLETION",
3472                             "consider using a completion\n" . $herecurr);
3473                }
3474
3475# recommend kstrto* over simple_strto* and strict_strto*
3476                if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
3477                        WARN("CONSIDER_KSTRTO",
3478                             "$1 is obsolete, use k$3 instead\n" . $herecurr);
3479                }
3480
3481# check for __initcall(), use device_initcall() explicitly please
3482                if ($line =~ /^.\s*__initcall\s*\(/) {
3483                        WARN("USE_DEVICE_INITCALL",
3484                             "please use device_initcall() instead of __initcall()\n" . $herecurr);
3485                }
3486
3487# check for various ops structs, ensure they are const.
3488                my $struct_ops = qr{acpi_dock_ops|
3489                                address_space_operations|
3490                                backlight_ops|
3491                                block_device_operations|
3492                                dentry_operations|
3493                                dev_pm_ops|
3494                                dma_map_ops|
3495                                extent_io_ops|
3496                                file_lock_operations|
3497                                file_operations|
3498                                hv_ops|
3499                                ide_dma_ops|
3500                                intel_dvo_dev_ops|
3501                                item_operations|
3502                                iwl_ops|
3503                                kgdb_arch|
3504                                kgdb_io|
3505                                kset_uevent_ops|
3506                                lock_manager_operations|
3507                                microcode_ops|
3508                                mtrr_ops|
3509                                neigh_ops|
3510                                nlmsvc_binding|
3511                                pci_raw_ops|
3512                                pipe_buf_operations|
3513                                platform_hibernation_ops|
3514                                platform_suspend_ops|
3515                                proto_ops|
3516                                rpc_pipe_ops|
3517                                seq_operations|
3518                                snd_ac97_build_ops|
3519                                soc_pcmcia_socket_ops|
3520                                stacktrace_ops|
3521                                sysfs_ops|
3522                                tty_operations|
3523                                usb_mon_operations|
3524                                wd_ops}x;
3525                if ($line !~ /\bconst\b/ &&
3526                    $line =~ /\bstruct\s+($struct_ops)\b/) {
3527                        WARN("CONST_STRUCT",
3528                             "struct $1 should normally be const\n" .
3529                                $herecurr);
3530                }
3531
3532# use of NR_CPUS is usually wrong
3533# ignore definitions of NR_CPUS and usage to define arrays as likely right
3534                if ($line =~ /\bNR_CPUS\b/ &&
3535                    $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
3536                    $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
3537                    $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
3538                    $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
3539                    $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
3540                {
3541                        WARN("NR_CPUS",
3542                             "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
3543                }
3544
3545# check for %L{u,d,i} in strings
3546                my $string;
3547                while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
3548                        $string = substr($rawline, $-[1], $+[1] - $-[1]);
3549                        $string =~ s/%%/__/g;
3550                        if ($string =~ /(?<!%)%L[udi]/) {
3551                                WARN("PRINTF_L",
3552                                     "\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
3553                                last;
3554                        }
3555                }
3556
3557# whine mightly about in_atomic
3558                if ($line =~ /\bin_atomic\s*\(/) {
3559                        if ($realfile =~ m@^drivers/@) {
3560                                ERROR("IN_ATOMIC",
3561                                      "do not use in_atomic in drivers\n" . $herecurr);
3562                        } elsif ($realfile !~ m@^kernel/@) {
3563                                WARN("IN_ATOMIC",
3564                                     "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
3565                        }
3566                }
3567
3568# check for lockdep_set_novalidate_class
3569                if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
3570                    $line =~ /__lockdep_no_validate__\s*\)/ ) {
3571                        if ($realfile !~ m@^kernel/lockdep@ &&
3572                            $realfile !~ m@^include/linux/lockdep@ &&
3573                            $realfile !~ m@^drivers/base/core@) {
3574                                ERROR("LOCKDEP",
3575                                      "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
3576                        }
3577                }
3578
3579                if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
3580                    $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
3581                        WARN("EXPORTED_WORLD_WRITABLE",
3582                             "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
3583                }
3584        }
3585
3586        # If we have no input at all, then there is nothing to report on
3587        # so just keep quiet.
3588        if ($#rawlines == -1) {
3589                exit(0);
3590        }
3591
3592        # In mailback mode only produce a report in the negative, for
3593        # things that appear to be patches.
3594        if ($mailback && ($clean == 1 || !$is_patch)) {
3595                exit(0);
3596        }
3597
3598        # This is not a patch, and we are are in 'no-patch' mode so
3599        # just keep quiet.
3600        if (!$chk_patch && !$is_patch) {
3601                exit(0);
3602        }
3603
3604        if (!$is_patch) {
3605                ERROR("NOT_UNIFIED_DIFF",
3606                      "Does not appear to be a unified-diff format patch\n");
3607        }
3608        if ($is_patch && $chk_signoff && $signoff == 0) {
3609                ERROR("MISSING_SIGN_OFF",
3610                      "Missing Signed-off-by: line(s)\n");
3611        }
3612
3613        print report_dump();
3614        if ($summary && !($clean == 1 && $quiet == 1)) {
3615                print "$filename " if ($summary_file);
3616                print "total: $cnt_error errors, $cnt_warn warnings, " .
3617                        (($check)? "$cnt_chk checks, " : "") .
3618                        "$cnt_lines lines checked\n";
3619                print "\n" if ($quiet == 0);
3620        }
3621
3622        if ($quiet == 0) {
3623
3624                if ($^V lt 5.10.0) {
3625                        print("NOTE: perl $^V is not modern enough to detect all possible issues.\n");
3626                        print("An upgrade to at least perl v5.10.0 is suggested.\n\n");
3627                }
3628
3629                # If there were whitespace errors which cleanpatch can fix
3630                # then suggest that.
3631                if ($rpt_cleaners) {
3632                        print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
3633                        print "      scripts/cleanfile\n\n";
3634                        $rpt_cleaners = 0;
3635                }
3636        }
3637
3638        if ($quiet == 0 && keys %ignore_type) {
3639            print "NOTE: Ignored message types:";
3640            foreach my $ignore (sort keys %ignore_type) {
3641                print " $ignore";
3642            }
3643            print "\n\n";
3644        }
3645
3646        if ($clean == 1 && $quiet == 0) {
3647                print "$vname has no obvious style problems and is ready for submission.\n"
3648        }
3649        if ($clean == 0 && $quiet == 0) {
3650                print << "EOM";
3651$vname has style problems, please review.
3652
3653If any of these errors are false positives, please report
3654them to the maintainer, see CHECKPATCH in MAINTAINERS.
3655EOM
3656        }
3657
3658        return $clean;
3659}
3660
lxr.linux.no kindly hosted by Redpill Linpro AS, provider of Linux consulting and operations services since 1995.